adobe-ccp-recipes icon indicating copy to clipboard operation
adobe-ccp-recipes copied to clipboard

Add installed_path as env variable

Open rustymyers opened this issue 8 years ago • 3 comments

I'd like to use the installed_path variable in future processors. It seems to be included in the additional_pkginfo dict, but I don't believe I can pull values from that easily in future processors. Please let me know if I'm incorrect. Thanks

rustymyers avatar Oct 27 '17 15:10 rustymyers

Makes sense to me, is installed_path always set? (Thinking maybe not if one doesn’t get derived from the pig metadata.., or if not maybe we also need to give it a default value) Can’t easily check right now as I’m not at a computer. But yes, IMO this makes sense to pass on.

timsutton avatar Oct 27 '17 17:10 timsutton

I'm still working my way through the apps, so I'll check for any that are missing the value. A default value in the event it's missing would be fine. I'll let you know what I find. Thanks

rustymyers avatar Oct 27 '17 17:10 rustymyers

So, it appears that not all installers have the installed_path variable, but the env variable is only set when it expects to find one. This follows the current logic and should always contain a value when Application.json exists (Line 90-92: CreativeCloudVersion.py). In this case process_hd_installer() runs and the installed_path variable is set as an environment variable.

The recipe will error if it does not find the Application.json or the proxy.xml file, so future processors would not run with empty values when they expect installed_path to contain a string.

This merge does not seem to significantly change the workflow of the processor nor does it create empty environment variables. As far as I can tell, this should be a safe change.

Let me know your thoughts. Thanks!

rustymyers avatar Oct 31 '17 15:10 rustymyers