display_name pkginfo override being ignored

[sphen13]

I had a client who was a bit anal/confused when it came to the adobe versions and wants "(2018)" appended to the display_name in MSC. I figured - no big deal, ill just add that into the override file and we will be fine. Come to find out somewhere along the way this value is being ignored or trampled on in the autopkg recipe further up the line.

Doing a verbose run i see the appropriate override value being seen originally - but it gets re-written down the line. As a quick test, I modified the CreativeCloudVersioner.py file and removed line 218:

            'display_name': self.env["display_name"],

when i then re-run autopkg the display_name survives through the run properly.

Not being a whiz at python or autopkg I am not exactly sure what modification needs to be made. I would assume we would want to check if we are trying to override that value and keep it - otherwise use what the Creative Cloud Feed gives us.

Thoughts? Tried to be as thorough as possible. Thanks.

[gregneagle]

"we would want to check if we are trying to override that value and keep it - otherwise use what the Creative Cloud Feed gives us."

That's the part that is tricky! It would be easy to have it always use an admin-supplied name, or always use the name from the feed.

I suppose you could have the default value be a special string like "<use_feed_name>" and if it's that, use the name from the feed, otherwise use the (overridden) value.

[nathanperkins]

I'm running into this issue as well.

[gregneagle]

Since I have autopkg import into a testing catalog, I just manually fix the display name before/when I move the item to production. I think a PR would be accepted should someone write one...