talos
talos copied to clipboard
Update requirements.txt
sklearn is a misnomer for the actual scikit-learn library https://github.com/autonomio/talos/issues/594 @mikkokotila @matthewcarbone
You want to make a PR to Talos
Thanks so much :) First, please take a moment to carefully check through the below items:
Sanity
- [x] I'm aware of the implications of the proposed changes
- [x] Code is PEP8
- [x] I'm making the PR to
master - [ ] I've updated the versions based on Semantic Versioning
- [ ]
setup.py - [ ]
talos/__init__.py - [ ]
docs/index.html - [ ]
docs/_coverpage.md
- [ ]
Docs
- [ ] Docs are updated
Tests
- [ ] Changes have gone through actual use testing
- [ ] All local tests have passed (run ./test.sh in /talos)
- [ ] Tests have been updated to reflect the changes
@mathavraj this is a blast from the past. I haven't worked on Talos in a while, and it doesn't appear to be maintained actively right now. With that said, you're right and this is a good change. I don't have merge powers though but I see no reason not to merge this.
@mathavraj this is a blast from the past. I haven't worked on Talos in a while, and it doesn't appear to be maintained actively right now. With that said, you're right and this is a good change. I don't have merge powers though but I see no reason not to merge this.
Thank you for the prompt reply. I hope someone with merging powers would accept it. I have raised a similar pull request in wrangle also and currently in our application which is dependent on 300+ python packages, these are the only two packages with sklearn misnomer. Could you help me by guiding on who would be the right person to contact about this?
Thank you for the prompt reply. I hope someone with merging powers would accept it. I have raised a similar pull request in wrangle also and currently in our application which is dependent on 300+ python packages, these are the only two packages with sklearn misnomer. Could you help me by guiding on who would be the right person to contact about this?
That would be @mikkokotila 👍