neps icon indicating copy to clipboard operation
neps copied to clipboard

[Internal API] `user_priors`, `use_priors`, `disable_priors`

Open eddiebergman opened this issue 1 year ago • 2 comments

Currently there are many functions taking in user_priors: bool, SuccessiveHalvinh/Hyperband + Sampling policy takes in user_priors: bool and BayesianOptimizer's use disable_priors.

We should just have one, use_priors: bool as it leads to inconsistencies in yaml files and definitions of various objects, even worse, one is a double negative, i.e. disable_priors = False which implies use_priors = True.

@Neeratyoy

eddiebergman avatar Jul 02 '24 09:07 eddiebergman

I agree.

There are 2 ways to tackle this:

  • Either this is its own push that is handled along with the #28, or
  • This is taken care of part of the bigger BO structure refactor in plan

Neeratyoy avatar Jul 03 '24 00:07 Neeratyoy

I would vote for the first way, before the second one

eddiebergman avatar Jul 03 '24 08:07 eddiebergman