SMAC3 icon indicating copy to clipboard operation
SMAC3 copied to clipboard

TAE and TAE kwargs are not passed down in hydra and psmac

Open kstrauch94 opened this issue 5 years ago • 3 comments

Description

When using hydra and a custom TAE it will fail because it doesn't pass the TAE and its kwargs correctly. The exact spot in the hydra facade is in line 191. Here we pass down the TAE kwargs but not the tae. I think that simply adding tae_kwargs["tae"] = self._tae below line 191 can fix this.

The second place where this happens is in the psmac facade in line 255. Here, we pass neither the TAE or its kwargs.

Steps/Code to Reproduce

Run hydra with a custom TAE with more than the regular TAE arguments

Expected Results

smac runs smoothly

Actual Results

smac crashes

Versions

kstrauch94 avatar Apr 06 '20 14:04 kstrauch94

@AndreBiedenkapp do you have time to look into it?

mlindauer avatar Apr 06 '20 18:04 mlindauer

I'll look into it but it might be some time before I can get to it.

AndreBiedenkapp avatar Apr 09 '20 09:04 AndreBiedenkapp

I opened a pull request that should fix these issues. Hopefully, this makes them clearer.

kstrauch94 avatar Apr 10 '20 14:04 kstrauch94

We are very sorry that the stalebot closed the PR and that no one had the time to take care of this for over 2 years now.

However, psmac is not supported in 2.0 anymore and instead we support parallelism natively now. Furthermore, the hydra interface is redesigned for 2.0. Thus, we will close this issue.

alexandertornede avatar Mar 30 '23 09:03 alexandertornede