SMAC3 icon indicating copy to clipboard operation
SMAC3 copied to clipboard

Published 20 hours ago • verified publisher icon automl

Do not round up cutoff

Open mlindauer opened this issue 7 years ago • 4 comments

We round up the cutoff to the next integer so far. That's maybe necessary for the pynisher but in all other use cases (where we don't limit the runtime within SMAC) we should not touch the cutoff. Therefore, I would propose to drop the rounding in execute_ta_run.

mlindauer avatar May 11 '18 14:05 mlindauer

Fine by me, but we should then add it to the execution path via the pynisher.

mfeurer avatar May 16 '18 07:05 mfeurer

Should be fixed with #573.

PhMueller avatar Dec 03 '19 17:12 PhMueller

@PhMueller Was this fixed in any PR? You closed #573 before mergening and if I'm not wrong, it is still not fixed in the dev branch.

mlindauer avatar Jan 29 '20 08:01 mlindauer

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 17 '22 21:06 stale[bot]