RoBO icon indicating copy to clipboard operation
RoBO copied to clipboard

code in robo.acquisition_functions.marginalization.py

Open cjfcsjt opened this issue 5 years ago • 1 comments

should we change code line 75 : "estimator.model = None" to "estimator.cost_model" and change code line 77: "estimator.model = self.cost_model.models[I]" to "estimator.cost_model = self.cost_model.models[I]"

and should we delete delete line 33-47?

cjfcsjt avatar Apr 26 '19 02:04 cjfcsjt

Good catch! Could you send a pull request to change that?

aaronkl avatar Apr 30 '19 08:04 aaronkl