ParameterImportance
ParameterImportance copied to clipboard
An error found in influence-models
In influence_models.py line 115, the code is:
tmp_used = used[:i] + used[i:]
This line doesn't remove the ith element in used, maybe what you really want is sth like:
tmp_used = used[:i] + used[i+1:]
and also need to check whether i+1 is out of range.
For now, because 'tmp_used' is the same as 'used', backward pass actually did nothing.
Also in line 119 and 120, maybe we should use 'tmp_used' instead of 'used'?
Thank you for reporting this issue. The influence-models are currently not supported and not tested so there might be more issues with the influence-models.
Thank you for reporting this issue. The influence-models are currently not supported and not tested so there might be more issues with the influence-models.
OK, thanks for your response.