HpBandSter icon indicating copy to clipboard operation
HpBandSter copied to clipboard

Scipy.misc.factorial issue

Open pinnnnnn opened this issue 6 years ago • 5 comments
trafficstars

scipy recently moved factorial function from scipy.misc to scipy.special. Would you do a quick fix on the HpBandSter code to update it as well? Right now I can't use the package due to this issue.

pinnnnnn avatar Jun 13 '19 21:06 pinnnnnn

As a quick fix - install an older version of scipy where the factorial function is still located in misc. Would be great if the dependencies are tagged with a version in setup.py. :)

FelixKleineBoesing avatar Jun 13 '19 21:06 FelixKleineBoesing

This is odd, because factorial isn't used in this library directly. Could you please post the full error you get, so I can see in which dependency the problem occurs?

sfalkner avatar Jun 14 '19 18:06 sfalkner

`

ImportError Traceback (most recent call last) in 6 import hpbandster.core.result as hpres 7 import hpbandster.visualization as hv ----> 8 from hpbandster.optimizers import BOHB

~/.local/share/virtualenvs/SJH7CMRD/lib/python3.6/site-packages/hpbandster/optimizers/init.py in 1 from hpbandster.optimizers.randomsearch import RandomSearch 2 from hpbandster.optimizers.hyperband import HyperBand ----> 3 from hpbandster.optimizers.bohb import BOHB 4 from hpbandster.optimizers.h2bo import H2BO

~/.local/share/virtualenvs/SJH7CMRD/lib/python3.6/site-packages/hpbandster/optimizers/bohb.py in 12 from hpbandster.core.master import Master 13 from hpbandster.optimizers.iterations import SuccessiveHalving ---> 14 from hpbandster.optimizers.config_generators.bohb import BOHB as CG_BOHB 15 16 class BOHB(Master):

~/.local/share/virtualenvs/SJH7CMRD/lib/python3.6/site-packages/hpbandster/optimizers/config_generators/bohb.py in 10 import scipy.stats as sps 11 import scipy.optimize as spo ---> 12 import statsmodels.api as sm 13 14 from hpbandster.core.base_config_generator import base_config_generator

~/.local/share/virtualenvs/SJH7CMRD/lib/python3.6/site-packages/statsmodels/api.py in 14 from . import robust 15 from .robust.robust_linear_model import RLM ---> 16 from .discrete.discrete_model import (Poisson, Logit, Probit, 17 MNLogit, NegativeBinomial, 18 GeneralizedPoisson,

~/.local/share/virtualenvs/SJH7CMRD/lib/python3.6/site-packages/statsmodels/discrete/discrete_model.py in 43 44 from statsmodels.base.l1_slsqp import fit_l1_slsqp ---> 45 from statsmodels.distributions import genpoisson_p 46 47 try:

~/.local/share/virtualenvs/SJH7CMRD/lib/python3.6/site-packages/statsmodels/distributions/init.py in 1 from .empirical_distribution import ECDF, monotone_fn_inverter, StepFunction ----> 2 from .edgeworth import ExpandedNormal 3 from .discrete import genpoisson_p, zipoisson, zigenpoisson, zinegbin

~/.local/share/virtualenvs/SJH7CMRD/lib/python3.6/site-packages/statsmodels/distributions/edgeworth.py in 5 import numpy as np 6 from numpy.polynomial.hermite_e import HermiteE ----> 7 from scipy.misc import factorial 8 from scipy.stats import rv_continuous 9 import scipy.special as special

ImportError: cannot import name 'factorial' `

pinnnnnn avatar Jun 14 '19 20:06 pinnnnnn

So the import error is actually in statsmodels a library used for the kernel density estimators asmodels inside BOHB. So the issue is actually on there.Which version of statsmodels and scipy did you install?Am 14.06.2019 22:04 schrieb Peiyun Zhang [email protected]:ImportError Traceback (most recent call last) in 6 import hpbandster.core.result as hpres 7 import hpbandster.visualization as hv ----> 8 from hpbandster.optimizers import BOHB ~/.local/share/virtualenvs/SJH7CMRD/lib/python3.6/site-packages/hpbandster/optimizers/init.py in 1 from hpbandster.optimizers.randomsearch import RandomSearch 2 from hpbandster.optimizers.hyperband import HyperBand ----> 3 from hpbandster.optimizers.bohb import BOHB 4 from hpbandster.optimizers.h2bo import H2BO ~/.local/share/virtualenvs/SJH7CMRD/lib/python3.6/site-packages/hpbandster/optimizers/bohb.py in 12 from hpbandster.core.master import Master 13 from hpbandster.optimizers.iterations import SuccessiveHalving ---> 14 from hpbandster.optimizers.config_generators.bohb import BOHB as CG_BOHB 15 16 class BOHB(Master): ~/.local/share/virtualenvs/SJH7CMRD/lib/python3.6/site-packages/hpbandster/optimizers/config_generators/bohb.py in 10 import scipy.stats as sps 11 import scipy.optimize as spo ---> 12 import statsmodels.api as sm 13 14 from hpbandster.core.base_config_generator import base_config_generator ~/.local/share/virtualenvs/SJH7CMRD/lib/python3.6/site-packages/statsmodels/api.py in 14 from . import robust 15 from .robust.robust_linear_model import RLM ---> 16 from .discrete.discrete_model import (Poisson, Logit, Probit, 17 MNLogit, NegativeBinomial, 18 GeneralizedPoisson, ~/.local/share/virtualenvs/SJH7CMRD/lib/python3.6/site-packages/statsmodels/discrete/discrete_model.py in 43 44 from statsmodels.base.l1_slsqp import fit_l1_slsqp ---> 45 from statsmodels.distributions import genpoisson_p 46 47 try: ~/.local/share/virtualenvs/SJH7CMRD/lib/python3.6/site-packages/statsmodels/distributions/init.py in 1 from .empirical_distribution import ECDF, monotone_fn_inverter, StepFunction ----> 2 from .edgeworth import ExpandedNormal 3 from .discrete import genpoisson_p, zipoisson, zigenpoisson, zinegbin ~/.local/share/virtualenvs/SJH7CMRD/lib/python3.6/site-packages/statsmodels/distributions/edgeworth.py in 5 import numpy as np 6 from numpy.polynomial.hermite_e import HermiteE ----> 7 from scipy.misc import factorial 8 from scipy.stats import rv_continuous 9 import scipy.special as special ImportError: cannot import name 'factorial'

—You are receiving this because you commented.Reply to this email directly, view it on GitHub, or mute the thread.

sfalkner avatar Jun 15 '19 04:06 sfalkner

i have 1.3.0 for scipy and 0.9.0 for statsmodels.

pinnnnnn avatar Jun 17 '19 16:06 pinnnnnn