HpBandSter
HpBandSter copied to clipboard
find nic_name automatically if misspecified
Added functionality to catch exceptions when the network card name is misspecified or is None. This may be useful in cluster environments with several submission nodes in cases when the network interfaces are different among them and the login node
Codecov Report
Merging #29 into development will decrease coverage by
0.39%. The diff coverage is0%.
@@ Coverage Diff @@
## development #29 +/- ##
==============================================
- Coverage 40.67% 40.27% -0.4%
==============================================
Files 40 40
Lines 2611 2622 +11
==============================================
- Hits 1062 1056 -6
- Misses 1549 1566 +17
| Impacted Files | Coverage Δ | |
|---|---|---|
| hpbandster/utils.py | 0% <0%> (ø) |
:arrow_up: |
| hpbandster/core/master.py | 91.66% <0%> (-2.5%) |
:arrow_down: |
| hpbandster/core/dispatcher.py | 85.04% <0%> (-1.41%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 8f465db...358f591. Read the comment docs.
Hey Arber,
thanks for contributing. I think your functionality is very useful, but I don't think trying to guess the NIC should be the default behavior. Why don't you add a function guess_host that does what your code already does (maybe in a more portable way, maybe the socket module has the functionality to get the route to a given target).
Best,
Stefan