ConfigSpace icon indicating copy to clipboard operation
ConfigSpace copied to clipboard

Manually setting an value of a key of a Config through `__setitem__` invalidates it's `_values`

Open eddiebergman opened this issue 3 years ago • 2 comments
trafficstars

It does not seem to make sense that manually setting an item with config[key] = value should delete the entire attribute self._values. Looking through the rest of the code, it seems like this would break a lot of functionality.

eddiebergman avatar Dec 13 '21 12:12 eddiebergman

Looking through the rest of the code, it seems like this would break a lot of functionality.

Could you please provide further details here? I don't think we had any issues on this end yet.

mfeurer avatar Dec 14 '21 14:12 mfeurer

Just to document, after our discussion, we had a thought to make Configuration objects immutable to saveon validation time as we can guarantee validaty at construction time, rather than everytime it's queried.

eddiebergman avatar Dec 15 '21 05:12 eddiebergman