Autolab icon indicating copy to clipboard operation
Autolab copied to clipboard

Requiring bootstrap date picker in asset pipeline

Open rmzr7 opened this issue 8 years ago • 3 comments

Currently we are doing

//= require bootstrap-datetimepicker in application.js

Is there a reason why the time picker has to be loaded in every page?

rmzr7 avatar Mar 31 '16 06:03 rmzr7

I was wondering this as well. Perhaps it has something to do with the custom form builder 'FormBuilderWithDateTimeInput' ? It was added with it in 38c7733d, and the author explicitly mentioned adding this to the global application.js

zyx-billy avatar Mar 31 '16 17:03 zyx-billy

@zyx-billy oh yes, this isn't necessary though. However I don't think its a very important issue at this point.

Furthermore, if @devanshk moves the date picker to materialize then we wouldn't need to inject it into every page like this.

rmzr7 avatar Apr 06 '16 03:04 rmzr7

The UI's been updated to Materialize, but we need to make sure removing this won't break anything.

devanshk avatar Oct 14 '17 16:10 devanshk