Autolab icon indicating copy to clipboard operation
Autolab copied to clipboard

We should be notified if no-view routes fail

Open dlbucci opened this issue 9 years ago • 4 comments

Specifically, local_submit, log_submit, and autograde_done should be sending us emails if they fail, which doesn't happen because we (correctly) catch the errors before the global render_error function is called.

dlbucci avatar Apr 28 '15 20:04 dlbucci

@droh @cg2v @devanshk @zyx-billy this seems to be related to the log_submit silent failure issue with 15-122

rmzr7 avatar Oct 13 '16 04:10 rmzr7

#510 was the fix to this problem. Why was it closed as deprecated? It should still apply to 2.0. It would be really helpful if we can get all the error handling code into our handin & autograding routines.

zyx-billy avatar Oct 10 '17 16:10 zyx-billy

Not sure if log_submit is still being developed / used. Let me know if this is still an issue

victorhuangwq avatar Jun 18 '20 13:06 victorhuangwq

I know local_submit is still used at Carnegie Mellon. I get occasional error notifications about local_submit being used when an assignment is no longer accepting submissions, and there is an issue with the shared AFS space some courses are using not being cleaned up at the end of the semester.

Sites that do not have AFS cannot use local_submit as far as I know.

It probably makes sense to have some of these errors logged to the COURSE_LOGGER. I don't believe it makes sense to use ExceptionNotifier in more cases than it already is

Deprecating local_submit in favor of cli/API submit probably makes sense, but somebody has to convince the faculty to change their practices.

cg2v avatar Jun 18 '20 16:06 cg2v