Pass cuds through session storage to fix issue
Description
Passing cuds through session storage prevents the cookie that the cuds were previously passed through from overflowing.
Motivation and Context
Resolves issue #2274
How Has This Been Tested?
Tested locally by creating missing submissions for >400 students.
Types of changes
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
Checklist:
- [x] I have run rubocop and erblint for style check. If you haven't, run
overcommit --install && overcommit --signto use pre-commit hook for linting - [ ] My change requires a change to the documentation, which is located at Autolab Docs
- [ ] I have updated the documentation accordingly, included in this PR
Other issues / help required
If unsure, feel free to submit first and we'll help you along.
📝 Walkthrough
Walkthrough
The changes rework how missing student IDs are handled during submission creation. The previous approach, which passed missing IDs as URL parameters, has been replaced with a session storage mechanism. A new JavaScript function in the missing submissions view collects the IDs and stores them, while the submission creation view now retrieves these stored IDs during the page load, adjusts the form elements accordingly, and updates the URL with the retrieved IDs.
Changes
| File(s) | Change Summary |
|---|---|
| app/views/submissions/missing.html.erb | Added a new JavaScript function submitMissingIds that collects missing student IDs from the @missing array, stores them as a JSON string in session storage, and redirects the user to the submission creation page. The direct URL parameter usage has been removed, with a placeholder link ("#") now in place. |
| app/views/submissions/new.html.erb | Modified the check for course_user_datum_id from nil? to blank?. Introduced a JavaScript block that runs on DOMContentLoaded to retrieve stored IDs from session storage, update the input field for course_user_datum_id, toggle visibility of related form sections, and adjust the window location to include the retrieved IDs as a query parameter. A new div for stored IDs display was also added. |
Sequence Diagram(s)
sequenceDiagram
participant U as User
participant M as Missing Submissions Page
participant JS as JavaScript
participant S as sessionStorage
participant N as New Submission Page
U->>M: Click "Fill In Empty Submissions"
M->>JS: Trigger submitMissingIds()
JS->>S: Store missing student IDs (JSON)
JS->>M: Redirect to submission creation page
U->>N: Load New Submission Page
N->>JS: DOMContentLoaded event triggers
JS->>S: Retrieve stored IDs
JS-->>N: Update input field, toggle display, modify URL with IDs
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
🪧 Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
-
I pushed a fix in commit <commit_id>, please review it. -
Generate unit testing code for this file. -
Open a follow-up GitHub issue for this discussion.
-
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitaiin a new review comment at the desired location with your query. Examples:-
@coderabbitai generate unit testing code for this file. -
@coderabbitai modularize this function.
-
- PR comments: Tag
@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:-
@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase. -
@coderabbitai read src/utils.ts and generate unit testing code. -
@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format. -
@coderabbitai help me debug CodeRabbit configuration file.
-
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (Invoked using PR comments)
-
@coderabbitai pauseto pause the reviews on a PR. -
@coderabbitai resumeto resume the paused reviews. -
@coderabbitai reviewto trigger an incremental review. This is useful when automatic reviews are disabled for the repository. -
@coderabbitai full reviewto do a full review from scratch and review all the files again. -
@coderabbitai summaryto regenerate the summary of the PR. -
@coderabbitai generate docstringsto generate docstrings for this PR. -
@coderabbitai resolveresolve all the CodeRabbit review comments. -
@coderabbitai planto trigger planning for file edits and PR creation. -
@coderabbitai configurationto show the current CodeRabbit configuration for the repository. -
@coderabbitai helpto get help.
Other keywords and placeholders
- Add
@coderabbitai ignoreanywhere in the PR description to prevent this PR from being reviewed. - Add
@coderabbitai summaryto generate the high-level summary at a specific location in the PR description. - Add
@coderabbitaianywhere in the PR title to generate the title automatically.
CodeRabbit Configuration File (.coderabbit.yaml)
- You can programmatically configure CodeRabbit by adding a
.coderabbit.yamlfile to the root of your repository. - Please see the configuration documentation for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.