Disallow creating or updating scheduler if invalid

[jhs-panda]

Description

When creating or updating a scheduler, tests visual run to ensure action can be loaded and works. If visual run test works, allow scheduler creation/update. If visual run test doesn't work on creation, delete created scheduler. If visual run test doesn't work on update, reinstate previous scheduler prior to update attempt.

Motivation and Context

Resolves #2187

How Has This Been Tested?

Before: Allows creation as long as inputs to Scheduler Creation filled. However, when running scheduler, gets many errors.

After: Notes error if action does not exist or is not readable:

Notes error if action exists and is readable but cannot execute properly:

If update is not successful, notes error and reverts to previous state:

For successful actions that load properly, work when run:

Types of changes

• [x] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• [x] I have run rubocop and erblint for style check. If you haven't, run overcommit --install && overcommit --sign to use pre-commit hook for linting
• [ ] My change requires a change to the documentation, which is located at Autolab Docs
• [ ] I have updated the documentation accordingly, included in this PR

Other issues / help required

[coderabbitai[bot]]

📝 Walkthrough

Walkthrough

The changes made to the SchedulersController focus on improving the create, update, and visual_run actions by adding validations for the existence and readability of action files specified in the scheduler parameters. If these validations fail, users receive error messages and are redirected to the appropriate forms. New methods for validating and executing action files have also been introduced, enhancing error handling and allowing for rollback in case of failures during visual runs.

Changes

Files	Change Summary
app/controllers/schedulers_controller.rb	Enhanced create, update, and visual_run actions with validations for action files. Added methods for validating, running, and executing action files with improved error handling.

Assessment against linked issues

Objective	Addressed	Explanation
Validations could require the action to be an existing file (Issue #2187)	✅
The controller could require that a successful visual run occur before enabling a job (Issue #2187)	✅
Scheduler could auto-disable or do exponential back-off for failing jobs (Issue #2187)	❌	No implementation for auto-disable or back-off logic.
Scheduler errors that are likely to be course errors could be caught and logged but not passed to exception notifier (Issue #2187)	❓	Unclear if specific logging mechanisms were implemented.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.