Remark links on View Feedback page result in 500 responses

[javb99]

Your environment Let us know details such as

• WSUV's Autolab at https://autolab.encs.vancouver.wsu.edu
• WSUV is on commit: 30f198e
• Safari on macOS Big Sur

Steps To Reproduce Steps to reproduce the behavior:

1. Go to 'https://autolab.encs.vancouver.wsu.edu/courses/course/assessments/astar/viewFeedback?feedback=id&submission_id=id'
2. Click on TA feedback at the bottom of the page
3. See error

Current behavior Opens to a 500 server error page

Expected behavior Opens the submission source file with that specific feedback line visible

Screenshots

Result:

Expected Result:

[amartinez116]

Hi,

There have been two "Remarks" related bug fixes since the commit you are currently on:

Remarks if grades have not been released: https://github.com/autolab/Autolab/pull/1292 Remarks on non-archive file: https://github.com/autolab/Autolab/pull/1283

However, I believe the issue you are facing might have to do with #1292. Can you confirm whether the grades have been released for that assignment? Students should only be able to view TA feedback after the grading deadline has passed and those grades have been released which is what #1292 fixes.

Thanks!

[javb99]

The grades have been released for that assignment. It doesn't seem related to #1292 or #1292 based on their titles.

[damianhxy]

I am unable to reproduce the issue, if possible could you attach any logs?

[damianhxy]

Closing this as stale.

As far as I can tell, this isn't an issue anymore. When grades are released, the links work as expected. When grades are not released (or grading deadline is not past), the remarks section does not appear.

Edit: Noted that WSUV resolved this via https://gitlab.encs.vancouver.wsu.edu/autolab-project/m6/autolab/-/commit/d51577f0fe9c8aca9275578d5047b793dc33bf6f