autobrr icon indicating copy to clipboard operation
autobrr copied to clipboard

docs(contributing): add note that postgres tests require UTC

Open kenstir opened this issue 9 months ago • 2 comments

The tests fail if the host is not configured for UTC. A note in the CONTRIBUTING doc would have saved me hours debugging the failed test.

$ sudo timedatectl set-timezone America/New_York
$ go clean -testcache
$ go test ./internal/database -tags=integration
...
--- FAIL: TestFilterRepo_GetDownloadsByFilterId (0.03s)
    --- FAIL: TestFilterRepo_GetDownloadsByFilterId/GetDownloadsByFilterId_Succeeds_[postgres] (0.02s)
        filter_test.go:817:
                Error Trace:    /home/kenstir/opensource/autobrr/internal/database/filter_test.go:817
                Error:          Not equal:
                                expected: &domain.FilterDownloads{HourCount:0, DayCount:0, WeekCount:1, MonthCount:1, TotalCount:1}
                                actual  : &domain.FilterDownloads{HourCount:1, DayCount:1, WeekCount:1, MonthCount:1, TotalCount:1}

                                Diff:
                                --- Expected
                                +++ Actual
                                @@ -1,4 +1,4 @@
                                 (*domain.FilterDownloads)({
                                - HourCount: (int) 0,
                                - DayCount: (int) 0,
                                + HourCount: (int) 1,
                                + DayCount: (int) 1,
                                  WeekCount: (int) 1,
                Test:           TestFilterRepo_GetDownloadsByFilterId/GetDownloadsByFilterId_Succeeds_[postgres]
FAIL
FAIL    github.com/autobrr/autobrr/internal/database    1.513s

If you change to UTC, they pass:

$ sudo timedatectl set-timezone Etc/UTC
$ go clean -testcache
$ go test ./internal/database -tags=integration
ok      github.com/autobrr/autobrr/internal/database    1.505s

kenstir avatar May 11 '24 01:05 kenstir