xad icon indicating copy to clipboard operation
xad copied to clipboard

AppleClang15 patch

Open raneamri opened this issue 1 year ago • 3 comments

Description

Work in progress fix for AppleClang15. This fix involves adding a SIMD option for Apple Silicon architectures, with future aim of resolving the build issues on this architecture.

Type of change

  • Bug fix (non-breaking change which adds support for a platform)

raneamri avatar May 22 '24 10:05 raneamri

Test Results

    29 files  ±0      29 suites  ±0   10m 52s :stopwatch: +2s  1 275 tests ±0   1 275 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  36 937 runs  ±0  36 937 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit f1f86f4a. ± Comparison against base commit c17c084a.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar May 22 '24 11:05 github-actions[bot]

Regarding the failing Windows toolset 14.1 build, could you change the CI/CD so that MSVC 14.0 and 14.1 are using the runner image windows-2019 instead? This image seems to have both toolsets installed. You can see here that this already done for 14.0.

Given the differences between the different compiler versions and Mac architectures, I believe we should extend the CI/CD build into a wider matrix build (similar to Linux/Windows). You can see here that both Arm and Intel based runners are available, and we have Clang 14/15 to test with on each. Plus Debug/Release and coverage.

If you want to do that as part of this PR, that would be great. Otherwise it could also be done in a separate one.

Pull Request Test Coverage Report for Build 9364361988

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on feature/appleclang15-fix at 98.793%

Totals Coverage Status
Change from base Build 8921008543: 98.8%
Covered Lines: 2291
Relevant Lines: 2319

💛 - Coveralls

coveralls avatar Jun 03 '24 19:06 coveralls