Add to GNU ELPA?

[dgutov]

Many third-party projects consider this as a de-facto popup library. It would be good to be able to use it everywhere, including Company, if only to spare the users from having to set up the same faces when different popups are used.

In order to do that, all non-trivial contributors would have to sign copyright assignments to FSF. Is that feasible?

If this goes through, I'll try to take care of the current display bugs. You have several long-standing ones, and I believe most (all?) of them are fixed in Company's popup now.

[Silex]

@syohex: if all these bugs are really fixed in company's popup lib, I think it's worth it to backport them to auto-complete's popup no? What is the showstopper?

[syohex]

Sorry we have no plan to upload GNU ELPA. We don't establish release management now so we think that uploading GNU ELPA is no advantages.

[dgutov]

The advantage would be that Company would be able to use it. And any packages that use popup.el for visualization now would be possible to publish to GNU ELPA.

[Silex]

@syohex: what about my question about the bugfixes? If it's fixed in some fork it ought to be backported here

[dgutov]

If it's fixed in some fork

It's not a fork, it's a different package.

[Silex]

Oh okay... but my point still stands. There is someone (you) volonteering to fix a lot of long standing bugs and if it was me maintaining popup I'd be like ZOMG <3 <3 <3 <3.

It's surprising.

[jcs090218]

I have no objection to this, since this issue had the discussion 6 years ago. Just want to make sure if you guys are still interested in it.

Ping, @dgutov , @Silex .

Thanks! 😄

[dgutov]

That still requires copyright assignment. And the chances of obtaining copyright papers from all contributors are even more slim now.

[jcs090218]

I am curious on how are these copy assignment process? Sorry I don't have the experience on this. I think the first step would just need a list of contributors? 😕

[dgutov]

Indeed. You can obtain such list from Git history. Or simply git blame.

Then: https://www.gnu.org/software/emacs/manual/html_node/emacs/Copyright-Assignment.html

[tarsius]

git shortlog -n is a good way to get started.

[jcs090218]

This is the current result from command git shortlog -n.

Log here.

Syohei YOSHIDA (53):
Fix travis configuration file for using cl-lib
Merge pull request #53 from auto-complete/fix-travis
Use cl-lib functions instead of cl
Merge branch 'master' into use-cl-lib
Merge pull request #54 from auto-complete/use-cl-lib
Fix for byte compile warnings
Merge pull request #55 from auto-complete/fix-bytecompile-warnings
Merge pull request #56 from ryantm/cl-lib
Add 'nostrip' parameter to 'popup-tip'(#42)
Merge pull request #59 from auto-complete/add-unstrip-parameter
Delete trailing spaces
Merge pull request #60 from auto-complete/delete-trailing-spaces
Add 'nostrip' parameter explanation to docstring
Merge pull request #61 from auto-complete/add-nostrip-documentation
Support max-width for popup instance
Merge pull request #62 from auto-complete/support-max-width
Merge pull request #63 from aki2o/fix-deficient-help-delay
Merge pull request #64 from aki2o/cascade-isearch
Use Cask instead of 'git submodule'
remove .gitmodules
Fix for using cask
Merge pull request #71 from auto-complete/use-cask
Merge branch 'add-initial-index'
Untabify
add :initial-index parameter test
Merge pull request #73 from auto-complete/add-initial-index-test
Merge pull request #76 from ramnes/master
Merge pull request #78 from aki2o/fix-popup-delete
bump up version
Merge pull request #80 from ancane/master
refactoring #80
bump up version
Update Installation section
Add MELPA badges
Merge pull request #81 from auto-complete/fix-readme-about-installation
svg is better than png
Fix MELPA stable link
Merge pull request #91 from ancane/master
Fix for Emacs 24.5 issue
Merge pull request #95 from Konubinix/master
Update cl-lib version
Improve definition
Switch from apt package to evm
Update document about customize variables
Use https scheme as possible
Merge pull request #96 from auto-complete/improve
Merge pull request #99 from spwhitton/apt-get
Remove needless quote
Merge pull request #101 from auto-complete/needless-quote
Fix faces propertized by under popup tooltip
Merge pull request #106 from auto-complete/issue-105
Merge pull request #107 from danrharms/master
Fix for newer Cask directory hierarchy

Tomohiro Matsuyama (33):
Import from auto-complete repository.
Added README.
Refactoring and auto-test.
Added documentation.
Added commentary.
Added :always option for :scroll-bar argument.
Update copyright.
Add mouse support.
v0.5 bump.
Not to insert newlines.
Fixed cascade menu corruption.
Revert "Not to insert newlines."
Initial commit
Update README.md
Merge branch 'master' of github.com:m2ym/popup-el
Merge branch 'master' of github.com:auto-complete/popup-el
Remove junk.
Add Travis CI build status
Merge pull request #22 from froydnj/update-readme
Add some make rules for test.
Merge pull request #24 from tkf/summary-overflow
Merge pull request #30 from tkf/summary-face
Merge pull request #31 from tkf/inherit-face
Introduce version number
Merge pull request #23 from uk-ar/uk-ar-add-test-case
Merge pull request #41 from kostafey/master
Add :initial-cursor keyword option to popup-menu*.
Rename :initial-cursor keyword option to :cursor.
Merge pull request #74 from kenbeese/fixed-display-with-invisible-overlays
Add screenshot images
Update copyright
Merge pull request #93 from auto-complete/fix-for-24.5
Merge pull request #97 from markus1189/eldoc

yuuki arisawa (22):
Port some test cases from popup-interactive-test.el
Fix test case bug when batch mode.
Remove unused code.
Add check for columns of starting points.
Change popup-test-helper-overlays-to-text spec and function name to return overlays buffer.                                                                             Bug fix for test helper
Split setup macro to support extra setup
Add test case when point is on the corner
Setup for batch mode
Remove dependency on auto-complete
Change test helper spec
Add test for test helper
Remove unused code.
Add folding test case when on the corner
Add test case for margin
Add check for row position.
Merge pull request #17 from uk-ar/feature
Add test case:popup-tip(height)
Add test case:popup-tip(scroll-bar,min-height)
Add test case:popup-menu*,popup-cascade-menu
Add test case:popup-next,popup-previous,popup-select
Add test case:popup-scroll-down,popup-scroll-up

Takafumi Arakaki (20):
Use inhibit-read-only instead of buffer-read-only
Merge pull request #10 from tkf/inhibit-read-only
Add ERT as git submodule
git mv popup-test.el tests/popup-interactive-test.el
Add a simple test using ERT
Add tests/run-test.el
Add Travis CI configuration
Merge pull request #15 from tkf/travis-ci
Truncate summary when it is too long
Truncate summary first, then string itself
At least one space before summary, if possible
Refactoring: new variable in popup-create-line-string
Merge pull request #25 from tkf/truncated-summary
Add summary-face keyword argument to popup-create-line-string
Add summary-face keyword argument to popup-set-line-item
Handle summary-face in popup-draw
Define popup-summary-face
Define popup-menu-summary-face
Do not use summary-face for selected item
Use face inheritance to avoid duplication

jenchieh (7):
Removed looking for new maintainer.
Fixed some checkdoc warnings.
Bump version.
Fixed compatible to display line numbers mode in Emacs 26.1 or after.
Bump version.
Fixed compile warning, free variable from display line numbers.
Bump version.

uk-ar (5):
Replace popup-test-with-create-popup to popup-create
Replace helper functions for some tests. * popup-test-helper-get-overlays-buffer to popup-test-helper-buffer-contents * popup-test-helper-match-points to popup-t est-helper-rectangle-match
Change buffer-contents from string to propertied string for detecting end of popup.
Refactoring all test cases
Add test for #18, #19, #20

Hiroaki Otsu (4):
fixed deficient help-delay
fixed without ignore-errors
activate isearch in cascade menu
fix error on popup-delete when char-before return nil

Igor Shymko (3):
:initial-index respects real popup height(beyond first popup page)
Pass filtering function as an argument to popup-menu*
readme updated

kostafey (3):
Add next/previous page commands.
Remove meaningless let.
Add popup-isearch-yank.

Jen-Chieh Shen (2):
Merge pull request #113 from EdwardBetts/spelling
Merge pull request #112 from PuercoWork/patch-1

Ryan Mulligan (2):
Use cl-lib functions instead of cl in tests
remove require because popup already requires it

TAKAGI Kentaro (2):
Apply the patch of #8.
Fix test.

Dan Harms (1):
extend overriding of background face for isearch, selection

Edward Betts (1):
correct spelling mistake

Guillaume Gelin (1):
Ignore byte-compiled files

Javier Olachea (1):
Fix typo in the docstring of popup-x-string

Jonas Bernoulli (1):
Looking for new maintainer

Kiyoka Nishiyama (1):
Add: initial-index keyword argument to function `popup-menu*'. (initial-index argument is optional argument) Usage:   (popup-menu*    '(0 1 2 3)    :initial-inde x 2)

Markus Hauck (1):
Improve eldoc for `popup-tip` and `popup-menu*`

Nathan Froyd (1):
update README.md to tweak typos and grammar

Samuel Loury (1):
Allow the user to specify a custom function to build the regexp in isearch

Sean Whitton (1):
Debian and Ubuntu installation instructions

Let's not talk about the non-trivial part yet. Here is the full list of all the contributors on the list including there contributions.

• [ ] Syohei YOSHIDA (53) - @syohex
• [ ] Tomohiro Matsuyama (33) - @m2ym
• [ ] yuuki arisawa (22 + 5) - @uk-ar
• [ ] Takafumi Arakaki (20) - @tkf
• [x] jenchieh (7 + 2) - @jcs090218
• [ ] Hiroaki Otsu (4) - @aki2o
• [ ] Igor Shymko (3) - @ancane
• [ ] kostafey (3) - @kostafey
• [ ] Ryan Mulligan (2) - @ryantm
• [ ] TAKAGI Kentaro (2) - @kenbeese
• [ ] Dan Harms (1) - Unknown (commit on 31 May, 2016)
• [ ] Edward Betts (1) - @EdwardBetts
• [x] Guillaume Gelin (1) - @ramnes
• [ ] Javier Olachea (1) - Unknown (commit on 8 Aug, 2017)
• [x] Jonas Bernoulli (1) - @tarsius
• [ ] Kiyoka Nishiyama - (1) @kiyoka
• [x] Markus Hauck (1) - @markus1189
• [ ] Nathan Froyd (1) - @froydnj
• [ ] Samuel Loury (1) - @Konubinix
• [ ] Sean Whitton (1) - @spwhitton

I guess we just need all people on the list to sign copyright assignments to FSF? 😅

---

EDIT: Just in case if you are confused why you are being notify by this thread, we are planning on pushing this package to elpa and we need all contributors to sign copyright assignments to FSF (See the link here). Let us know what you think! Thanks! 😄

[tarsius]

I recommend that you look at the log on Github to easily match legal names to Github usernames. Once you have compiled the list you should post it here to invite these people to comment. I should not just update the above list; make a new post aka "comment". That way you can prefix it with some friendly words and also I am not sure whether users are notified when you edit an existing post to include their handle.

[jcs090218]

I recommend that you look at the log on Github to easily match legal names to Github usernames.

Yeah, great call.

Once you have compiled the list you should post it here to invite these people to comment. I should not just update the above list; make a new post aka "comment".

Will do!

That way you can prefix it with some friendly words and also I am not sure whether users are notified when you edit an existing post to include their handle.

Yeah, I don't think people will get notification if you edit existing post which is fine because I want .a complete and organized list before I can invite/ask them later on. :)

---

BTW, some of them are missing. I am still looking for it though. 😕

[tarsius]

I can invite/ask them later on

Ah okay. Makes sense. Not sure it works that way though. You might already have invited them just now. :stuck_out_tongue_winking_eye:

[jcs090218]

Okay, I have a full list here. But with two unknown contributors. Javier Olachea and Dan Harms.

Ah okay. Makes sense. Not sure it works that way though. You might already have invited them just now.

Oh, really?? 😳 I thought it wouldn't notify by editing the existing post... hmm... I mean if they read through the thread they might already know what to do. I will still add some more information just in case if anyone came here is confused. 😄

[markus1189]

I'm okay with signing the copyright assignment :+1: I hope it's enough to do them electronically, feel free to send me the documents via E-Mail.

[jcs090218]

I actually have no experience on signing the copyright assignment to FSF, do you guys have any idea?

Ping @tarsius, @dgutov.

Thanks! :)

[dgutov]

Basically, everyone has to follow the instructions here: https://code.orgmode.org/bzg/org-mode/raw/master/request-assign-future.txt

But you might check with emacs-devel first (maybe the form has changed lately, though I doubt that).

[ramnes]

A previous link mentions:

We can accept small changes (roughly, fewer than 15 lines) without an assignment. This is a cumulative limit (e.g., three separate 5 line patches) over all your contributions.

With a one line diff, can I unsubscribe from this issue? :)

[jcs090218]

Cool, I have emailed to [email protected] and do get the pdf document to sign. The whole process is simple. :)

@ramnes I think you could? I will check the checkbox indicate that you will pass this process.

[markus1189]

@jcs090218 The same for me, the change is small enough :)

[jcs090218]

@markus1189 Got it! Thanks! :)

[tarsius]

My only commit is the "Looking for new maintainer" commit. Also signed the papers anyway.

[AkibAzmain]

@jcs090218,

I have a off-topic question which we shouldn't probably ask here.

Cool, I have emailed to [email protected] and do get the pdf document to sign. The whole process is simple. :)

How did you sign? Using GPG? Or by hand on a printed copy of it? If you signed by hand, then how did you send it? Emailed a digital copy of the paper? Or a traditional mail? And finally, what information did they ask for?

[jcs090218]

@AkibAzmain It's been a while that I signed the paper.

I think I printed out then scanned it back to PC. It shouldn't be that hard. :)

[AkibAzmain]

@jcs090218 Thanks. Do you still plan to add popup.el to GNU ELPA? That would be a great addition. (Though it would be greater to implement child frames in terminal.)

[jcs090218]

Yeah, we wish to add this package to help but many people haven't replied to this issue, so I don't know how long would it take to accomplish this...

Not sure if a child frame can be implemented in the terminal though.

[AkibAzmain]

Not sure if a child frame can be implemented in the terminal though.

It should be possible to implement child frame. According to Eli Zaretskii:

The difficulty in implementing child frames on TTY are not because Emacs cannot draw on TTY at arbitrary coordinates, it's because there are fundamental design principles on which TTY display is based. I'd actually recommend to implement child frames on TTY as a special kind of window that is free of the "normal" window geometry restrictions.

However, I think this discussion is completely off-topic here, since it has nothing to do with popup.el.