spicedb icon indicating copy to clipboard operation
spicedb copied to clipboard

Published 20 hours ago • verified publisher icon authzed

LookupWatchApi basic implementation

Open hagneva1 opened this issue 2 years ago • 5 comments

Start a PR to exchange with you about our first implementation. Notify that some unit tests doesn't work, we'd love if you can watch them and have your feedback.

hagneva1 avatar Aug 31 '22 15:08 hagneva1

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

github-actions[bot] avatar Aug 31 '22 15:08 github-actions[bot]

I have read the CLA Document and I hereby sign the CLA

gonzalad avatar Aug 31 '22 15:08 gonzalad

I have read the CLA Document and I hereby sign the CLA

hagneva1 avatar Sep 01 '22 09:09 hagneva1

For traceability: this is part of https://github.com/authzed/spicedb/issues/207

vroldanbet avatar Sep 07 '22 12:09 vroldanbet

All issues so far have been fixed

We also improved the right-hand-side handling when RHS subject type = req.SubjectType see https://github.com/authzed/spicedb/pull/776/commits/8a05a8da885b7183f1850ff69293e96dfca749f8

@josephschorr Let us know if there's something more to do (if there's something more to do before resolving conflicts)

Thanks !

gonzalad avatar Sep 20 '22 10:09 gonzalad

I added more commits:

  • I splitted the content of processUpdate function in 3 functions (lookupSubjects, lookupResources, computePermissions)
  • merged main branch content into this PR

@josephschorr : tell me if something is remaining

thanks, Adrian

gonzalad avatar Sep 22 '22 10:09 gonzalad

@josephschorr Are there any news on this api? We have been waiting for the LookupWatch API for 2 years and without it we cannot start using spicedb. Do you plan to merge this anytime soon?

henkosch avatar Feb 09 '24 22:02 henkosch

This PR is definitely too stale to do anything with other than close, so I'll do that now.

In the time developing SpiceDB since this PR was created, we've developed a better understanding of use-cases and formed some new opinions for this particular problem. Before any development takes place, I think it'll require a new proposal and round of community feedback, especially when it comes to the API design and performance characteristics.

We'd appreciate your feedback on such a proposal, too; especially if it's been a dealbreaker for your adoption. If public feedback isn't something you feel comfortable with, you can always join the SpiceDB Discord and chat to one of the SpiceDB maintainers in private.

jzelinskie avatar Feb 09 '24 22:02 jzelinskie