spicedb icon indicating copy to clipboard operation
spicedb copied to clipboard

Test `SELECT FOR UPDATE` for CRDB overlap

Open ecordell opened this issue 1 year ago • 2 comments

When we initially implemented overlap keys, SELECT FOR UPDATE didn't suffice to make writes conflict. There was some language in more recent CRDB releases that suggest it may work now. It's worth updating the e2e test suite with new CRDB versions and testing SELECT FOR UPDATE instead.

ecordell avatar Jan 06 '25 20:01 ecordell

@ecordell can you please clarify why SELECT FOR UPDATE didn't suffice to cause a conflict?

vroldanbet avatar Jun 27 '25 10:06 vroldanbet

There's some other discussion here: https://github.com/authzed/spicedb/issues/2241#issuecomment-2652388873

Basically the test suite proved that select for update could still get reversed timestamps. My full notes from the experiment are here: https://hackmd.io/88_ybweDS0m7lKLj_0uqHw?view

ecordell avatar Jun 27 '25 16:06 ecordell