symfony icon indicating copy to clipboard operation
symfony copied to clipboard

Remove $container parameter from controller constructors

Open mkilmanas opened this issue 1 year ago • 0 comments

Changes

Fix for issue #189

  • Removed $container parameter from controllers (because it is injected via setContainer() by Symfony DI)
  • Added exception in psalm config not to report this as a problem

References

#189

Testing

Tested statically and on a Symfony 7.0 project (although controllers are not executed there - verified that container builds without problems and bin/console list:container reports no problems)

Tested only statically on Symfony 6.4.

Testing on older Symfony versions would be much appreciated.

[ ] This change adds test coverage

[x] This change has been tested on the latest version of Symfony

Checklist

[x] I have read the Auth0 general contribution guidelines

[x] I have read the Auth0 Code of Conduct

[x] All existing and new tests complete without errors

mkilmanas avatar Jan 22 '24 11:01 mkilmanas