jwks-rsa-java icon indicating copy to clipboard operation
jwks-rsa-java copied to clipboard

Retrieval of Jwk token is blocking

Open huntc opened this issue 3 years ago • 2 comments

This could also be viewed as a feature request, but I think it is more of a bug given that I've later discovered the following line of JwkProvider to be a blocking call:

    Jwk get(String keyId) throws JwkException;

Should we not return a future instead?

huntc avatar Apr 28 '22 03:04 huntc

Hi @huntc, I guess we could have added this to the documentation to ensure it was conveyed properly that it is a blocking call. Returning to the future would be ideal. It would be great if you can provide a PR for this, we could help you with it if needed.

poovamraj avatar May 03 '22 06:05 poovamraj

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you have not received a response for our team (apologies for the delay) and this is still a blocker, please reply with additional information or just a ping. Thank you for your contribution! 🙇‍♂️

stale[bot] avatar Aug 13 '22 09:08 stale[bot]

I agree with @poovamraj we should at least update the documentation to ensure its clear. And if we can add async support in a nice way, that's something we can consider.

jimmyjames avatar Sep 06 '22 13:09 jimmyjames