jwks-rsa-java
jwks-rsa-java copied to clipboard
Retrieval of Jwk token is blocking
This could also be viewed as a feature request, but I think it is more of a bug given that I've later discovered the following line of JwkProvider to be a blocking call:
Jwk get(String keyId) throws JwkException;
Should we not return a future instead?
Hi @huntc, I guess we could have added this to the documentation to ensure it was conveyed properly that it is a blocking call. Returning to the future would be ideal. It would be great if you can provide a PR for this, we could help you with it if needed.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you have not received a response for our team (apologies for the delay) and this is still a blocker, please reply with additional information or just a ping. Thank you for your contribution! 🙇♂️
I agree with @poovamraj we should at least update the documentation to ensure its clear. And if we can add async support in a nice way, that's something we can consider.