cosmos
cosmos copied to clipboard
Heading component does not support h5
Describe the bug
There is no support for h5 in Heading
component
Expected behavior
Heading
supports h5.
Screenshots
Cosmos version:
0.8.1
Additional context
@landitus What's the font-size and font-weight for h5?
I can jump on it if you tell me the font-size
and font-weight
for h5
FYI here are the size and weight for h3
and h4
Heading.Element[3] = BaseHeading.withComponent('h3').extend`
font-size: 18px; /* TO-DO: tokenize */
font-weight: ${fonts.weight.bold};
`
Heading.Element[4] = BaseHeading.withComponent('h4').extend`
font-size: 14px;
font-weight: ${fonts.weight.medium};
`
Thanks @jvelezpo ! We need to do a design/spec/review for this issue first. You can check that this one is marked with the design needed
tag, to note that we need a design spec first before jumping into code.Β π
Once we have the spec attached to the issue, we will continue with it.
Just to be on the safe side it will be great to have also h6
.
We can introduce this as we work on #1290