cosmos icon indicating copy to clipboard operation
cosmos copied to clipboard

Heading component does not support h5

Open jcenturion opened this issue 5 years ago β€’ 5 comments

Describe the bug

There is no support for h5 in Heading component

Expected behavior

Heading supports h5.

Screenshots

image

Cosmos version:

0.8.1

Additional context

jcenturion avatar Nov 27 '18 17:11 jcenturion

@landitus What's the font-size and font-weight for h5?

siddharthkp avatar Dec 03 '18 07:12 siddharthkp

I can jump on it if you tell me the font-size and font-weight for h5

FYI here are the size and weight for h3 and h4

Heading.Element[3] = BaseHeading.withComponent('h3').extend`
  font-size: 18px; /* TO-DO: tokenize */
  font-weight: ${fonts.weight.bold};
`

Heading.Element[4] = BaseHeading.withComponent('h4').extend`
  font-size: 14px;
  font-weight: ${fonts.weight.medium};
`

jvelezpo avatar Dec 11 '18 23:12 jvelezpo

Thanks @jvelezpo ! We need to do a design/spec/review for this issue first. You can check that this one is marked with the design needed tag, to note that we need a design spec first before jumping into code.Β πŸ™‚

Once we have the spec attached to the issue, we will continue with it.

landitus avatar Dec 11 '18 23:12 landitus

Just to be on the safe side it will be great to have also h6.

hzalaz avatar Jan 14 '19 20:01 hzalaz

We can introduce this as we work on #1290

andresgalante avatar Jan 14 '19 20:01 andresgalante