auth0-vue icon indicating copy to clipboard operation
auth0-vue copied to clipboard

Routes not awaited

Open illegalnumbers opened this issue 11 months ago • 1 comments

Checklist

  • [X] The issue can be reproduced in the auth0-vue sample app (or N/A).
  • [X] I have looked into the Readme, Examples, and FAQ and have not found a suitable solution or answer.
  • [X] I have looked into the API documentation and have not found a suitable solution or answer.
  • [X] I have searched the issues and have not found a suitable solution or answer.
  • [X] I have searched the Auth0 Community forums and have not found a suitable solution or answer.
  • [X] I agree to the terms within the Auth0 Code of Conduct.

Description

Route calls, such as this https://github.com/auth0/auth0-vue/blob/efe1d39a0244fd072a527df97f87ab355501851d/src/plugin.ts#L185 and https://github.com/auth0/auth0-vue/blob/efe1d39a0244fd072a527df97f87ab355501851d/src/plugin.ts#L171, should be awaited as they are async.

Reproduction

Code is not awaited

Additional context

No response

auth0-vue version

latest master

Vue version

any

Which browsers have you tested in?

Chrome

illegalnumbers avatar Mar 05 '24 21:03 illegalnumbers

Thanks for reaching out. The Vue Router docs is also very explicit about not awaiting this in the basic use-case, see: https://router.vuejs.org/guide/essentials/navigation.html. That said, they do have a section to call out the possibility to await route changes, see: https://router.vuejs.org/guide/advanced/navigation-failures.html

Can you help us understand what the problem is you are facing that would be solved by awaiting this?

Thanks.

frederikprijck avatar Mar 06 '24 08:03 frederikprijck