auth0-oidc-client-net icon indicating copy to clipboard operation
auth0-oidc-client-net copied to clipboard

Update to WebView2

Open Authfix opened this issue 4 years ago • 2 comments

Changes

We cannot use Auth0 WPF library in dotnet 6 project because of a deprecated dependency. We need to remove package Microsoft.Toolkit.Wpf.UI.Controls.WebView and replace it by Microsoft.Web.WebView2.

Main classes remain unchanged.

Bump to version 4.0 because changing the main dependency.

References

Deprecated notice https://docs.microsoft.com/en-us/dotnet/api/microsoft.toolkit.wpf.ui.controls.webview?view=win-comm-toolkit-dotnet-6.1

Testing

Run the WPF and WinForms applications in "Interactive Test Apps" folder.

Checklist

Authfix avatar Feb 25 '22 16:02 Authfix

Thanks for opening this PR, we always appreciate people willing to improve the SDK.

The support for .NET 5 and 6 has been discussed a few times, and you should be able to use this SDK as-is in a .NET 6 project using WebView 2, here are the steps I took to do so: https://github.com/auth0/auth0-oidc-client-net/issues/209#issuecomment-1039203957.

As said in that comment, I understand this isn't ideal. But because it's not blocking, I think it would be better to consider adding support for WebView2 in a non-breaking way.

frederikprijck avatar Feb 27 '22 21:02 frederikprijck

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you have not received a response for our team (apologies for the delay) and this is still a blocker, please reply with additional information or just a ping. Thank you for your contribution! 🙇‍♂️

stale[bot] avatar Jun 12 '22 18:06 stale[bot]

Closing this, as this can not be merged in it's current state and has been stale for a while.

frederikprijck avatar Sep 16 '22 11:09 frederikprijck