auth0-java icon indicating copy to clipboard operation
auth0-java copied to clipboard

Avoid unnecessary http client creation

Open jlannoy opened this issue 1 year ago • 1 comments

Checklist

  • [X] I have looked into the Readme and Examples, and have not found a suitable solution or answer.
  • [X] I have looked into the API documentation and have not found a suitable solution or answer.
  • [X] I have searched the issues and have not found a suitable solution or answer.
  • [X] I have searched the Auth0 Community forums and have not found a suitable solution or answer.
  • [X] I agree to the terms within the Auth0 Code of Conduct.

Describe the problem you'd like to have solved

Similar to the issue #480, the ManagmentAPI builder set the value of the httpClient to an instantiated http client, which could then be overridden by callers.

Describe the ideal solution

Objects.nonNull(httpClient) ? httpClient : DefaultHttpClient.newBuilder().build() should be used in the build() method.

Alternatives and current workarounds

None.

Additional context

No response

jlannoy avatar Feb 20 '24 21:02 jlannoy