auth0-java-mvc-common icon indicating copy to clipboard operation
auth0-java-mvc-common copied to clipboard

Upgrade to JDK 17 and JakartaEE 6.0

Open TareqK opened this issue 2 years ago • 5 comments

Changes

This is a refactor that upgrades the mvc-common library to Jakarta EE6.0 and JDK 17, allowing use on more modern servers and libraries - the tests were also fixed to account for the expiration of tokens. The main changes were to the build and namespaces of imports - with some changes to the tests using regexes.

References

solves #111

Testing

  • [x] This change adds test coverage
  • [x] This change has been tested on the latest version of Java or why not

Checklist

Added Context

This will break the current API as it changes all the required args to another package. Will fail CI check for API Changes - but this is expected and part of the issue.

TareqK avatar Dec 11 '23 10:12 TareqK

Further Context : Upgraded only to jdk17 instead of 21 because the oss-plugin didnt run with jdk 21 - and gradle support for jdk 21 is fairly new.

TareqK avatar Dec 11 '23 10:12 TareqK

👋 hey @TareqK, thanks for the PR! This is something that we plan to do in a new major version. We may revisit this PR when work on that release begins, but it's not something we can accept right now as it would be a breaking change that would require a new major version release.

jimmyjames avatar Dec 18 '23 16:12 jimmyjames

hi @jimmyjames

any estimate (months or years) of when the next major version is planned for would be helpful. If it is not planned for the near future, was thinking of maintaining a fork until the fix is released, since it is blocking moving to spring boot 3

nmanandhar avatar Feb 27 '24 04:02 nmanandhar

Hi @TareqK,

Thank you for the PR

Can you please sign your commits without which I won't be able to add your commits.

tanya732 avatar Jan 30 '25 11:01 tanya732

Hi!

Let me actually do some fixed because I see there are conflicts first and I'll get it handled over the weekend hopefully

TareqK avatar Jan 30 '25 11:01 TareqK

Hello @TareqK, @jimmyjames, @tanya732 , are there any plans to merge this MR soon? When do you plan to publish the next major release? Otherwise, what is the official way to work with auth0 and jdk 17 or 21?

mammer42 avatar May 08 '25 12:05 mammer42

Hi @mammer42

Thanks for checking in! The multi-Java version testing setup is working smoothly across JDK 8, 11, 17, and 21. We've confirmed that all tests are running successfully on these versions.

As for the major release, it's on our roadmap, and we're targeting an initial version in the coming months. This will include multiple improvements, feature requests, and plugin upgrades, including this PR. We’ll keep everyone updated as we get closer to the release.

tanya732 avatar May 16 '25 09:05 tanya732

Hello Apologies for the inactivity. I am going to open a new PR based on a fresh fork, as Equiptal has suspended its engineering activities and the org is no longer functioning on github.

TareqK avatar May 16 '25 17:05 TareqK

Hello @tanya732 , im closing this in favour of #156 , which has the same changes and is signed. Lets move the idsucssion there

TareqK avatar May 16 '25 18:05 TareqK