auth0-deploy-cli icon indicating copy to clipboard operation
auth0-deploy-cli copied to clipboard

Formatted liquid templates fail in universal_login

Open zicvic opened this issue 1 year ago • 0 comments

Checklist

  • [X] I have looked into the README and have not found a suitable solution or answer.
  • [X] I have looked into the documentation and have not found a suitable solution or answer.
  • [X] I have searched the issues and have not found a suitable solution or answer.
  • [X] I have upgraded to the latest version of this tool and the issue still persists.
  • [X] I have searched the Auth0 Community forums and have not found a suitable solution or answer.
  • [X] I agree to the terms within the Auth0 Code of Conduct.

Description

When using a standard formatter for liquid code the deployment fails due to misalignment on expected formatting of the {%- auth0: head -%} and {%- auth0: widget -%} tags.

Expectation

When I use a standard formatter of the supported coding languages the deployment should not fail due to an additional space added to adhere to the formatting rules.

Reproduction

  1. Formatting the universal_login.liquid with these settings (in vscode):
{
  "[liquid]": {
    "editor.defaultFormatter": "sissel.shopify-liquid",
    "editor.formatOnSave": true
},
  "[liquid-css]": {
    "editor.defaultFormatter": "sissel.shopify-liquid",
    "editor.formatOnSave": true
}
  1. Results in that the tags {%- auth0:head -%} and {%- auth0:widget -%} are re formatted to {%- auth0: head -%} and {%- auth0: widget -%} (notice added space)

  2. Running a0deploy import the results in this error message:

2024-10-30T15:10:00.997Z - error: Problem running command deploy during stage processChanges when processing type branding
2024-10-30T15:10:00.997Z - error: The template must contain a single auth0:head tag and at least one auth0:widget tag.
  1. Reformatting and removing the spaces results in a successful deployment

Deploy CLI version

7.23.4

Node version

v20.18.0

zicvic avatar Oct 31 '24 06:10 zicvic