auth0-deploy-cli icon indicating copy to clipboard operation
auth0-deploy-cli copied to clipboard

Unmark sandbox_version as readonly

Open hmd34 opened this issue 3 years ago • 1 comments

🔧 Changes

Previously, there was a issue about sandbox_version Import. https://github.com/auth0/auth0-deploy-cli/issues/69 So mark sandbox_version to readonly, and remove sandbox_version in export.

Now seems to have been resolved that issue. Fix so that sandbox_version is exported again.

📚 References

Fix: https://github.com/auth0/auth0-deploy-cli/issues/682

🔬 Testing

Following steps

  1. Check the Node.js runtime version in tenant advanced settings
  2. Export settings with a0deploy
  3. Check to appears sandbox_version in tenant.json
  4. Compare 1 and 3 step's Node version

📝 Checklist

  • [x] All new/changed/fixed functionality is covered by tests (or N/A)
  • [x] I have added documentation for all new/changed functionality (or N/A)

hmd34 avatar Oct 26 '22 13:10 hmd34

E2E tests failed. I saw errors and don't know why failed. Do I need to take any action?

hmd34 avatar Oct 26 '22 13:10 hmd34

cc @willvedd

Widcket avatar Nov 07 '22 13:11 Widcket

@hmd34 I haven't forgotten about this. Can confirm that support for updating sandbox_version was added sometime between #69 and now. I want to be particularly careful to not introduce any regressions for folks so need to double-check that including this property in payloads is compatible with all environments and permutations of the API.

willvedd avatar Nov 14 '22 19:11 willvedd

Despite the CircleCI checks suggesting otherwise, all tests are indeed passing. My suspicion is that this fork's lack of environment variables being injected is interfering with the recordings. Going ahead with a merge anyway, we'll have to fix that integration later.

willvedd avatar Jan 31 '23 22:01 willvedd

@willvedd So sorry for delayed response and thank you for your work.

hmd34 avatar Feb 12 '23 04:02 hmd34