angular2-jwt icon indicating copy to clipboard operation
angular2-jwt copied to clipboard

Angular 11 SUPPORT

Open blindsz opened this issue 3 years ago • 11 comments

Hi, when can we expect angular 11 support??

blindsz avatar Apr 17 '21 05:04 blindsz

I am currently using angular v11 and I am not facing any issues....

AnthonyNahas avatar May 16 '21 15:05 AnthonyNahas

I use Angular 11 and I have problems, the configuration that is added to the JwtModule does not react, it does nothing.

In Angular 10 I did not have this problem, I created a project from scratch with angular 11 and it did not work either, so the library only works until version 10, I hope you can review this problem

jimyhdolores avatar May 21 '21 18:05 jimyhdolores

in angular 1 1 got: node_modules/angular2-jwt/angular2-jwt.d.ts:1:77 - error TS2307: Cannot find module '@angular/http' or its corresponding type declarations.

danielicy avatar May 25 '21 06:05 danielicy

I'm using angular 12 without issue

jongbonga avatar Jun 18 '21 19:06 jongbonga

confirmed with angular 11 without issue.

Yicong-Huang avatar Sep 15 '21 18:09 Yicong-Huang

We've used this package with Angular 10 and 13 without issue. Have you made sure to install the right version? If you use version 4.2.0 it should work.

Rlcolli4 avatar Dec 28 '21 02:12 Rlcolli4

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you have not received a response for our team (apologies for the delay) and this is still a blocker, please reply with additional information or just a ping. Thank you for your contribution! 🙇‍♂️

stale[bot] avatar Apr 16 '22 03:04 stale[bot]

Hi, it's still an issue for us, we are waiting for the Ivy support using the partial compilation mode.

edbzn avatar Apr 25 '22 11:04 edbzn

@edbzn sre you using auth0/angular-jwt or auth0/angular2-jwt? For Ivy our team had to switch to the newer version to work with the Ivy compiler - it didn't take us long to switch over in our projects. Here is the versions we are currently running: "@angular/core": "~13.1.1" "@angular/cli": "^13.1.2", "rxjs": "^6.5.2", "@auth0/angular-jwt": "5.0.2",

Rlcolli4 avatar Jun 03 '22 16:06 Rlcolli4

@Rlcolli4 @auth0/[email protected] was published with ViewEngine which means ngcc needs to be run by the consumer to bring Ivy compatibility, here is the log of the webpack plugin processing angular-jwt using ngcc:

⠙ Generating browser application bundles (phase: setup)...
- @auth0/angular-jwt [es2015/esm2015] (git+https://github.com/auth0/angular2-jwt) 

If we want to get rid of ngcc one day we have to encourage library authors to publish using the partial compilation mode.

edbzn avatar Jun 03 '22 17:06 edbzn

Interesting, we haven't seen that when we run locally or when we send a build out. Maybe we have missed it. I will double check our outputs, but currently we do not have any issue running that in our set up.

Rlcolli4 avatar Jun 03 '22 18:06 Rlcolli4

Closing this in favor of #712

frederikprijck avatar Sep 21 '22 07:09 frederikprijck