Difficulty reading build-toolchain.bash due to Boolean conditionals

[ryandesign]

I find it confusing that most of the Boolean conditionals in build-toolchain.bash check whether a variable != false or != true . It would be more straightforward to check if the variable = true or = false .

Furthermore, some of the Boolean variables indicate that something should be done (like BUILD_68K) while others indicate that something should not be done (like SKIP_THIRDPARTY). It would be clearer if all the Boolean variables had the same meaning—for example, change SKIP_THIRDPARTY to BUILD_THIRDPARTY and reverse the conditionals.

Would you accept a pull request making these changes?

[ryandesign]

This confusion may have contributed for example to the mistake made in #122.

[autc04]

Yes, I would, feel free to clean up.

In my defense, when I started that script, it was probably the first time I used shell as an actual programming language..