Dave Rolsky comments

Results 94 comments of


                                            Dave Rolsky

feat: Proof of concept: Use ubi as a library instead of as a binary

I honestly don't understand the internals of mise well enough to know if this PR is done or not.

feat: Proof of concept: Use ubi as a library instead of as a binary

> it seems to be failing but it's unclear why: > > ``` > E2E ./backend/test_ubi_token > $ GITHUB_TOKEN=foobar mise install -f ubi:goreleaser/[email protected] 2>&1 > Error: [GITHUB_TOKEN=foobar mise install -f...

feat: Proof of concept: Use ubi as a library instead of as a binary

Also, I think it'd be nice to add support for some other features, like telling `ubi` the executable name or telling it that the release it picks must match a...

feat: Proof of concept: Use ubi as a library instead of as a binary

> mise has support for tool config which should be documented more clearly: > > ```toml > [tools] > # send arbitrary options to the plugin, passed as: > #...

feat: Proof of concept: Use ubi as a library instead of as a binary

@jdx I think this is mostly ready, but it wouldn't hurt to add some additional e2e tests, I think.

feat: Proof of concept: Use ubi as a library instead of as a binary

Also, there's an e2e test failure I don't understand - https://github.com/jdx/mise/actions/runs/10548662451/job/29222829250?pr=2290

feat: Proof of concept: Use ubi as a library instead of as a binary

I just merged from your `main` and resolved the conflicts.

feat: Proof of concept: Use ubi as a library instead of as a binary

But now I'm getting a very confusing compilation error: ``` cargo test --workspace Compiling mise v2024.10.2 (/home/autarch/projects/mise) error[E0277]: the trait bound `toml_edit::Item: From` is not satisfied --> src/cli/settings/set.rs:64:42 | 64...

Added match() function based on boolean predicate func

This looks good to me, but I would name this `Matches`, not `Match`. That reads a bit better when used in an `if` clause, IMO. I'd also note that the...

Cross building x86_64 and arm64 on a arm64 machine inside docker does not work

This looks like an error from trying to execute cross, not a bug in cross. There's no cross release for arm64, so I wonder if my action is just installing...