Austin Woon Quan

Results 17 comments of Austin Woon Quan
trafficstars

> I think we can revisit the general solution in a new PR and merge this PR once the windows test pass I have removed the sourcemaps outputs from `output.js`...

@igalklebanov ive addressed all of the PR comments, could i check if this is ready to be merged?

> @austinwoon CI seems to run forever, can you check this? This problem seems to not be from my PR. I checked out `master` and also have a `pending` test...

> I think that in general, this plugin (which is not a core functionality) is unnecessarily overly tested - 65 lines of source code vs. 828 lines of test code....

> ValueNode.createImmediate(null) Thanks again for the thoughtful response. I finally made time to update the code. I tried to do the `ValueNode.createImmediate(null)` method but that actually caused a regression spotted...

> Wouldn't it be better to transform it to `1 = 0` ? This is what the Laravel's query builder typically do, I think. Like: > > > > ```...

> There are several fixes in newer versions related to the job scheduler, I think that if you upgrade to the latest version you will not be able to reproduce...