eth.build
eth.build copied to clipboard
austintgriffith
Add charts display
Added charts display component.
Library used does not support area and column charts, but I added more outside the list.
Polar and Radar charts.
@austintgriffith @Polycarpik
Closes #22
Hi! I just tried out this PR (currently live on ethbuild.uniswap.ch) and I can't get it to actually draw the charts. What am I missing?
I tried different array/object variations...
@ChristophSiegenthaler @Polycarpik I've fix the issue. Had to add styling to the charts for each of the individual charts and all labels to the generic for each of them as well.
Thanks for the effort! Strange, it still doesn't work for me. I see the added label input but otherwise not much changed:
Do you see anything I do wrong?
Try using the code input and convert to any from object and feed into it. I was able to reproduce your error and fixed it. It works. My data was small yet it showed up. /cc @ChristophSiegenthaler
Mine still look weird whatever I try with code/object/any. It sometimes shows input but 10 times the amount of input data that I feed it. Could you please post a sample screenshot of yours so that I can try the same inputs?
Mine still look weird whatever I try with code/object/any. It sometimes shows input but 10 times the amount of input data that I feed it. Could you please post a sample screenshot of yours so that I can try the same inputs?
Sure, I'll post a screenshot today
Weird, I still get the same, after the last commit:
It works perfectly now. Please check your side
@ChristophSiegenthaler https://www.loom.com/share/112f634e4ea9436a99dd8759a17229d5
@iamonuwa Hh, sorry, I used netlify to build it but then I tested with an older deployed version. It kind of works now but I still have some issue with scatter and scaling...
@iamonuwa Hh, sorry, I used netlify to build it but then I tested with an older deployed version. It kind of works now but I still have some issue with scatter and scaling...
Scatter requires objects parsed in as list not strings.
Hey hey @iamonuwa , I finally got the time to test this, sorry for the delays.
First of all, the line chart is missing.
Second of all – Radar and polar are simply not readable
But that concerns most of the charts.
Also, when I try to scale the component with chart – chart becomes bigger, but it floats down and does not come back into the component. And with every next resize it goes down and down the screen.
And the small one – block is missing the title.
Thanks for putting so much effort into it! We can agree that that's gonna be the last change request unless something radically horrible shows up.
@Polycarpik I've fixed the other issues raised. But scatter has not fix presently. I had to remove it. I've tried every possible combination to pass objects and convert to array but it fails.
Cool, thanks! @iamonuwa
So, Polar is good and scalable, Radar still has the very same issues
I did not find where is 'second dataset' used. Why have you added it?
'Labels' are used sometimes as labels on charts, sometimes as dataset (for line, for example). Can we rename if to 'first dataset', so after all we have only 3 inputs: 'type', 'first dataset', 'second dataset'.
Block is still missing the title:
It should be green (as all display blocks are) and have 'CHARTS' written on it. Example:
Also, no need for the word 'DISPLAY' here, just 'CHARTS' will be cool:
Hey @Polycarpik the second dataset is for radar charts. It requires 2 datasets to work properly. I'll make the changes needed. Thanks
Okie-doke, i've took a look there. @iamonuwa
Out of all outlined issues – (1) radar is still behaves weird when block size changed, see the gif in previous message.
Also radar works well with 2 inputs:
It is just super-confusing that sometimes label is used as label and sometimes as actual dataset. This is why I requested to rename it to First Dataset and Second Dataset. And delete the third property (the very bottom one, currently names 'Second Dataset').
Let me know if you have any questions.
@Polycarpik thanks for the review. I left the label for a user to enter the legends/key of the chart. I sent you a dm on discord as well. We can discuss in realtime over there.
Alright, I tried the latest iteration, some thoughts:
- it's not self explanatory. How should the user know what charts are available? He can look in the code, sure, but wouldn't more guidance in the UI help? Same for the second data set (- The bar chart defaults to scale the y axis to max and min value, which leads to the smallest bar always being invisible. IMO defaulting to 0 - max would be better but maybe this is just me)
- Chart scaling "escalates quickly" ... doesn't work for most chart types (doughnut, radar, pie ..)
- Scatter not working
- Why can't one connect the text input box directly to label, only the string box?
It's nice to play around with it and I really appreciate the work you put into it but the issues above make using it very inconsistent and it feels unfinished/buggy.