eth.build icon indicating copy to clipboard operation
eth.build copied to clipboard

"Save" fails

Open coinop-logan opened this issue 4 years ago • 5 comments

On Firefox. I loaded the one you built for SmokeSignal, then posted to SmokeSignal, then rearranged it a bit. Much to my dismay I couldn't seem to save it at all! Clicking save has no visual effect at all.

Console output upon clicking save:

1716578f597 0ms Starting document clone 2.3ee5998b.chunk.js:1:6701788
1716578f597 539ms Document cloned, using computed rendering 2.3ee5998b.chunk.js:1:6701788
1716578f597 539ms Starting DOM parsing 2.3ee5998b.chunk.js:1:6701788
1716578f597 595ms Added image data:image/svg+xml,%3Csvg%20xmlns%3D%22http%3A%2F%2Fwww.w3.org%2F2000%2Fsvg%22%20style%3D%22width%3A%2024px%3B%20height%3A%2024px%3B%20opacity%3A%200.95%3B%22%20viewBox%3D%220%200%2024%2024%22%20class%3D%22%22%20title%3D%22Scan%22%3E%3Cpath%20fill%3D%22%23 2.3ee5998b.chunk.js:1:6701788
1716578f597 660ms Starting renderer 2.3ee5998b.chunk.js:1:6701788
NS_ERROR_FAILURE 2.3ee5998b.chunk.js:1

coinop-logan avatar Apr 10 '20 19:04 coinop-logan

Also experiencing this issue Firefoz for Ubuntu v81.0

pi0neerpat avatar Oct 06 '20 20:10 pi0neerpat

Able to reproduce the error on firefox. Looks like it has to do with html2canvas https://github.com/niklasvh/html2canvas/issues/2046 Looking in to it.

Aragar199 avatar Aug 14 '21 16:08 Aragar199

Was not able to fix, but I did test some things that did not work:

  • hard code the rendered image to a smaller size, sometimes canvas draw doesn't work if the image is larger than the browser window limitations
  • update html2canvas to the latest version 1.3.1
  • added "allowTaint:true" flag to see if it was an issue with cross domain rendering
  • tried rendering jpg instead of img

Going to have to move on to other issues for now. If someone else wants to take a crack at this, feel free.

Aragar199 avatar Aug 15 '21 14:08 Aragar199

I'll take a look this week

grahamtallen avatar Aug 16 '21 16:08 grahamtallen

@grahamtallen were you able to look into it?

programmer-ke avatar May 28 '23 10:05 programmer-ke