burner-wallet icon indicating copy to clipboard operation
burner-wallet copied to clipboard

Introduce a config file

Open TimDaub opened this issue 5 years ago β€’ 1 comments

Scope

  • Right now the burner-wallet is configured in App.js. Variables are overwritten based on the location of the browser.
  • LeapDAO has proposed a config.js file in their burner fork that could easily be used to make the project more configurable: https://github.com/leapdao/burner-wallet/pull/134
  • @dmihal also proposed a nice way to handle configuration: https://github.com/austintgriffith/burner-wallet/pull/194/commits/4ff5d2f4b9d4ad37ed970eb2aa5784fa066e880a
  • Note that in @dmihal's spec, there might be hints on how this config.js file should look like: https://docs.google.com/document/d/1GtS_NxhxSt9XVTphp4fWRvjeQjIVT8WbYsqpKAlWbfE/edit If you think we should implement according to this spec, feel free to ping @dmihal for advice.

Deliverables

  • Somehow combine or decide between one of the two two approaches outlined above and introduce a config.js file to the repo

Gains for the project

  • Easier whitelabeling and configuration

Roles

bounty gardener: @TimDaub / 10% bounty worker: name / 75% bounty reviewer: name / 15%

TimDaub avatar Jun 04 '19 15:06 TimDaub

I would totally love some configuration options, allowing to configure network node, symbols, token names and turning some features on/off based on a particular need of a particular pop-up economy.

Alternatively, a documentation on how to do this would be great. Not only changing constants in App.js, but turning on/off some particular features (some pop-up economies will not have a prediction market, some don't need Wyre or exchanges).

jooray avatar Nov 30 '19 22:11 jooray