ydkjs-exercises icon indicating copy to clipboard operation
ydkjs-exercises copied to clipboard

List items being rendered non-semantically in BookHome

Open hagnerd opened this issue 6 years ago • 2 comments

Within the <BookHome /> component, the <li> is being rendered within the <Link> component.

Inside a <ul> or <ol> all direct children should be <li>'s.

This would be a good first issue for someone looking to contribute.

image

hagnerd avatar Sep 07 '18 01:09 hagnerd

Agreed! Thanks for opening this issue!

austintackaberry avatar Sep 07 '18 05:09 austintackaberry

Semantics fixed, PR created #204

kshitijpurwar avatar Oct 02 '18 06:10 kshitijpurwar