subtracks icon indicating copy to clipboard operation
subtracks copied to clipboard

Scrobbling does not follow any standards

Open arg274 opened this issue 2 years ago • 4 comments

Describe the bug Subtracks does not consider any criteria for submitting a scrobble, Tracks are scrobbled instantly the moment they are tapped on, which leads to unintended data in a user's audioscrobbler profile, even when the user does not intend to play the track at all.

To Reproduce Steps to reproduce the behavior:

  1. Enable server-side scrobbling
  2. Play any track
  3. Track gets submitted instantly

Expected behavior The last.fm standards mandate that a scrobble should only be submitted when the track is 30 seconds longer and when the track in question has been played for at least half its duration, or after 4 minutes, whichever condition is fulfilled first.

Screenshots N/A

Smartphone

  • Device: Pocophone F1
  • OS: Android 11 (AOSP-based custom ROM)
  • Subtracks version: 1.2.0

Additional context A track that has just started playing should set submission to false in the /scrobble endpoint of the Subsonic API until the conditions for submission are met. This means not only making the scrobbling aware of the player state, but also implementing a separate counter that does not rely on the current seek position but rather the actual duration spent on playing the track (so that the track does not get scrobbled for seeking past half its duration despite not actually being played for that long).

arg274 avatar Apr 22 '22 14:04 arg274

I've noticed this also. I accidentally tapped on a song and quickly clicked on another, and both were scrobbled as if I listened to both completely

kpcenti avatar Apr 23 '22 03:04 kpcenti

@arg274 Thanks for the details on this, can't say I was actually aware that there is a standard for scrobbling but that should make it easier to implement the change!

austinried avatar Apr 23 '22 12:04 austinried

Note for probably myself on implementing this: https://github.com/ocetnik/react-native-background-timer

austinried avatar May 03 '22 00:05 austinried

Came here also to report the same issue with scrobbling, thanks for looking into this!

AlexKalopsia avatar Dec 17 '22 23:12 AlexKalopsia