asset-builder icon indicating copy to clipboard operation
asset-builder copied to clipboard

add ability for user to extend built in types

Open austinpray opened this issue 9 years ago • 2 comments

User should be able to provide a map of their custom types to override the built in types: https://github.com/austinpray/asset-builder/blob/db6d6739b4324becde7326c8afedb3941ced8e00/lib/types.json

Related: https://github.com/austinpray/asset-builder/issues/33

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/10814760-add-ability-for-user-to-extend-built-in-types?utm_campaign=plugin&utm_content=tracker%2F8853550&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F8853550&utm_medium=issues&utm_source=github).

austinpray avatar Apr 09 '15 22:04 austinpray

I've looked through the source. trying to figure out where custom types should go.

I don't think a new types.json should be required. Is there a reason that the default types are in a json file anyways? Seems like the defaults could be added somewhere like this: https://github.com/kalenjohnson/asset-builder/blob/master/lib/processManifest.js#L19-22

And then we could add an optional files override to manifest.json.

I played with the code a bit, but if the files are actually in the manifest object, then you would need to pass the full manifest object here, but then I think that's starting to fight the structure you have set up. Probably need to set up another prototype function.

kalenjohnson avatar Apr 24 '15 06:04 kalenjohnson

@kalenjohnson the first step is to write some failing tests ;)

austinpray avatar Apr 24 '15 06:04 austinpray