react-native-hamsters icon indicating copy to clipboard operation
react-native-hamsters copied to clipboard

Not compatible with RN 0.72

Open talaikis opened this issue 1 year ago • 5 comments

Build error:

react-native-hamsters\android\src\main\java\com\reactlibrary\ReactContextBuilder.java:15: error: cannot find symbol
import com.facebook.react.bridge.NativeModuleCallExceptionHandler;
                                ^
  symbol:   class NativeModuleCallExceptionHandler
  location: package com.facebook.react.bridge
react-native-hamsters\android\src\main\java\com\reactlibrary\ReactContextBuilder.java:135: error: cannot find symbol
    private NativeModuleCallExceptionHandler createNativeModuleExceptionHandler() {
            ^
  symbol:   class NativeModuleCallExceptionHandler
  location: class ReactContextBuilder
react-native-hamsters\android\src\main\java\com\reactlibrary\ThreadBaseReactPackage.java:14: error: package com.facebook.react.modules.storage does not exist
import com.facebook.react.modules.storage.AsyncStorageModule;
                                         ^
react-native-hamsters\android\src\main\java\com\reactlibrary\ReactContextBuilder.java:79: error: cannot find symbol
            reactContext.setNativeModuleCallExceptionHandler(devSupportManager);
                        ^
  symbol:   method setNativeModuleCallExceptionHandler(DevSupportManager)
  location: variable reactContext of type ReactApplicationContext
react-native-hamsters\android\src\main\java\com\reactlibrary\ReactContextBuilder.java:91: error: cannot find symbol
                .setNativeModuleCallExceptionHandler(devSupportManager != null
                ^
  symbol:   method setNativeModuleCallExceptionHandler(devSupport[...]ler())
  location: class Builder
react-native-hamsters\android\src\main\java\com\reactlibrary\ReactContextBuilder.java:136: error: cannot find symbol
        return new NativeModuleCallExceptionHandler() {
                   ^
  symbol:   class NativeModuleCallExceptionHandler
  location: class ReactContextBuilder
react-native-hamsters\android\src\main\java\com\reactlibrary\ReactContextBuilder.java:137: error: method does not override or implement a method from a supertype
            @Override
            ^
react-native-hamsters\android\src\main\java\com\reactlibrary\ThreadBaseReactPackage.java:46: error: cannot find symbol
                new AsyncStorageModule(catalystApplicationContext),
                    ^
  symbol:   class AsyncStorageModule
  location: class ThreadBaseReactPackage

talaikis avatar Dec 26 '23 18:12 talaikis

Same here.

brunoleitem avatar Feb 14 '24 20:02 brunoleitem

Thank you for making this ticket, I am aware of the issue and there is progress being made to resolve this, you can follow the updates here. https://github.com/joltup/react-native-threads/issues/155#issuecomment-1970635104 unfortunately it's not going to be a quick fix to support the latest version of react native.

austinksmith avatar Mar 19 '24 12:03 austinksmith

Right now the official support is up to version 0.69 , I apologize if that doesn't work for you but right now I simply don't have the time or budget to focus on fixing this. I am always open to pull requests if you are good with java :)

austinksmith avatar Mar 19 '24 12:03 austinksmith

Just an update, soon I will begin development of a JSI (C++) implementation for versions of react native greater than 0.69, I will specifically test for 0.72 version support and validate it works, it will be a new repo which I will link here when its ready so I can maintain this repo for 0.69 and older version support.

austinksmith avatar Sep 07 '24 10:09 austinksmith

If you want to follow along with the development here is the new project, currently I am working on android support first and then I will extend to IOS once I have android working as I have android devices to test with but no ios devices.

https://github.com/austinksmith/react-native-workerbee

Contributions are greatly appreciated.

austinksmith avatar Oct 13 '24 16:10 austinksmith