rainbow-bridge-client icon indicating copy to clipboard operation
rainbow-bridge-client copied to clipboard

getBalance is not a generic ERC20 metadata

Open 0x3bfc opened this issue 3 years ago • 0 comments

The user's balance is user centric metadata. It should be used outside the getErc20Data.

https://github.com/aurora-is-near/rainbow-bridge-client/blob/f1039b490da07915b94b84056b22c00ff3aef01b/packages/nep141-erc20/src/natural-erc20/getMetadata.js#L72

and getBalance should be exported here:

https://github.com/aurora-is-near/rainbow-bridge-client/blob/f1039b490da07915b94b84056b22c00ff3aef01b/packages/nep141-erc20/src/natural-erc20/getMetadata.js#L5

0x3bfc avatar Jun 29 '21 11:06 0x3bfc