validation icon indicating copy to clipboard operation
validation copied to clipboard

Typings incomplete / using any instead of type

Open MJLHThomassen-Sorama opened this issue 3 years ago • 2 comments

I'm submitting a bug report

  • Library Version: 2.0.0-rc2

Please tell us about your environment:

  • Operating System: Windows 10

  • Node Version: v14.15.5

  • NPM Version: 6.14.8

  • Browser: all

  • Language: TypeScript

Current behavior:

In the aurelia-validation.d.ts file currently there this bit of code:

export declare class ValidationRules {
	private static parsers;
	static initialize(messageParser: ValidationMessageParser, propertyParser: PropertyAccessorParser): void;
	/**
	 * Target a property with validation rules.
	 * @param property The property to target. Can be the property name or a property accessor function.
	 */
	static ensure<TObject, TValue>(property: string | number | PropertyAccessor<TObject, TValue>): FluentRules<TObject, any>;

The ensure() method returns a FluentRules<TObject, any>, wile i would expect it to return a FluentRules<TObject, TValue>. The FluentRules class is fully typed properly with the TValue parameter, but all instances of FluentRules specify "any" as the second type parameter which cancels all the nice typescript benefits of type checking on the value.

Expected/desired behavior: All methods that return a FluentRules have it properly typed, 'any' is not used.

MJLHThomassen-Sorama avatar Apr 19 '21 09:04 MJLHThomassen-Sorama

I think the typing issue is fixed from the beginning in Aurelia v2. However, I am sure if we have the bandwidth to fix v1 issues :(

Sayan751 avatar Apr 24 '21 11:04 Sayan751

Would you like to provide a pull request for it @MJLHThomassen-Sorama ?

Alexander-Taran avatar Aug 11 '21 21:08 Alexander-Taran