template-lint icon indicating copy to clipboard operation
template-lint copied to clipboard

- Enhanched the require rule with an extra required attribute from.bind, this or the from are now required

Open LittleGnome opened this issue 5 years ago • 5 comments

  • Enhanched the require rule with an extra required attribute from.bind, this or the from are now required.
  • Removed unused imports/parameters;
  • Some other code clean up and update the README.MD;

Make sure you check the following:

  • [x] you are making a pull request for the develop branch
  • [ ] unless trivial, a corresponding issue exists for this PR (reference it)
  • [ ] if this PR fixes the issue, then include fix #
  • [x] you've ran gulp test and it passes the lint
  • [x] tests don't fail (except tests in 'failing.spec.ts')

Note: Requests to pull into master from a fork will be rejected.

LittleGnome avatar Jan 14 '20 16:01 LittleGnome

@LittleGnome We actually don't support binding the from attribute of the require element. The require element is much like an ES2015 import and must be statically determined by the template compiler.

EisenbergEffect avatar Jan 14 '20 22:01 EisenbergEffect

But when we use it as followed, it's totally fine, but Aurelia template linter doesn' t accept is. <template repeat.for="requiredModule of requiredModules"><require from.bind="requiredModule"></require><template> Is there another way to configure or write something, so we can still use the Aurelia template linter and still have the require rule?

LittleGnome avatar Jan 15 '20 06:01 LittleGnome

@LittleGnome I have to be honest, I'm not sure how that is working. Let me loop in @bigopon . Perhaps there was some change at some point I'm unaware of that enables that to work.

EisenbergEffect avatar Jan 15 '20 07:01 EisenbergEffect

Hello @bigipon, do you have some time to look into this pull request?

LittleGnome avatar Jan 19 '20 21:01 LittleGnome

Oops, missed this. Ill ha e a look in a few hours

bigopon avatar Jan 19 '20 21:01 bigopon