loader-webpack icon indicating copy to clipboard operation
loader-webpack copied to clipboard

Published 20 hours ago • verified publisher icon aurelia

refactor(loader-webpack): refactored aysnc await code to use promises

Open suneelv opened this issue 7 years ago • 10 comments

In response to https://github.com/aurelia/skeleton-navigation/issues/821 FYI This didn't prevent the out of stack space error in ie11

suneelv avatar May 18 '17 20:05 suneelv

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar May 18 '17 20:05 CLAassistant

@jods4 Thanks for the comments. I am new to this. I will update the pull request with changes.

suneelv avatar May 18 '17 20:05 suneelv

@jods4 Yes I am always returning promises from all the old async methods. I am not really familiar with what loader-webpack is doing. So it would be better if you can just skim through it once again.

suneelv avatar May 18 '17 21:05 suneelv

Not requiring the async downlevel helpers from TS will make the code smaller... but sadly the stack overflow is still not fixed :(

jods4 avatar May 18 '17 21:05 jods4

@niieani Is this good to merge then?

EisenbergEffect avatar Jul 30 '17 21:07 EisenbergEffect

@EisenbergEffect It would be good to test against the skeleton (I haven't) but otherwise looks good. Perhaps we can release tagged as beta or RC first, and if no issues show, re-release as final.

niieani avatar Jul 31 '17 09:07 niieani

@jods4 Have we tested this? What should we do with this PR?

EisenbergEffect avatar Dec 10 '17 17:12 EisenbergEffect

@EisenbergEffect The runtime loader is really @niieani's work. I have reviewed the PR and it looks good, I haven't tested it, though.

jods4 avatar Dec 10 '17 22:12 jods4

Yes, looks good as @jods4 said, but I haven't tested either.

niieani avatar Dec 12 '17 21:12 niieani

Has anyone tested this out yet?

EisenbergEffect avatar Jun 19 '18 03:06 EisenbergEffect