robinhood-node icon indicating copy to clipboard operation
robinhood-node copied to clipboard

trigger and time (in force) are reversed in README

Open chiefsmurph opened this issue 6 years ago • 2 comments

If I am not mistaken, the buy order and sell order documentation in the README has the trigger and time's reversed.

chiefsmurph avatar Sep 19 '18 22:09 chiefsmurph

It is either reverse in the README, or reverse in the .d.ts. Either way, something is reversed.

prmichaelsen avatar Nov 13 '18 03:11 prmichaelsen

README is wrong. The .d.ts has some issues too.

Example of a good for day - stop loss (at stop price it becomes a market order) "time_in_force":"gfd","fees":"0.00","cumulative_quantity":"0.00000","stop_price":"7.00000000","reject_reason":null,"instrument":"https://api.robinhood.com/instruments/39ff611b-84e7-425b-bfb8-6fe2a983fcf3/","state":"queued","trigger":"stop","type": "market"

Example of a good till canceled - stop limit (at stop price it becomes a limit order at price) "time_in_force":"gtc","fees":"0.00","stop_price":"7.01000000","reject_reason":null,"instrument":"https://api.robinhood.com/instruments/39ff611b-84e7-425b-bfb8-6fe2a983fcf3/","state":"queued","trigger":"stop","override_dtbp_checks":false,"type":"limit",

Limit order would be "type":"limit", "price":"7.00000" , "trigger":"immediate"
Market order would be "type":"Market", "price":"7.35000" , "trigger":"immediate"
(they don't do real market orders so price is still used)

.d.ts should be something like: export type TriggerTypes = 'immediate' | 'stop' ;

export type TimeInForceTypes = 'gfd' | 'gtc';

tagroup avatar Jan 24 '19 06:01 tagroup