Aura.Cli icon indicating copy to clipboard operation
Aura.Cli copied to clipboard

fix shortOptionCapturesValue fails getting 0 or '0'

Open fcamp opened this issue 5 years ago • 3 comments

Adds a safer emtpy check in GetoptParser::shortOptionCapturesValue

fcamp avatar Oct 24 '19 09:10 fcamp

Looks we need to fix the Travis config and installation of phpunit to fix issues. Interested in looking into it ?

harikt avatar Oct 26 '19 03:10 harikt

@harikt I noticed that tests use an old version of phpunit. Updating them won't be too much work.

However ContainerTest is based on a class outside the repository

fcamp avatar Oct 28 '19 09:10 fcamp

Do you want to make any changes to the container test? If not composer will manage dependencies

harikt avatar Oct 28 '19 17:10 harikt