blur-my-shell icon indicating copy to clipboard operation
blur-my-shell copied to clipboard

Extension gives a blank screen on Gnome 46 beta

Open alissonlauffer opened this issue 1 year ago • 1 comments

Hello and thanks for doing such a great job with this extension. It's a must have in my Gnome installation.

Today I upgraded to Gnome 46.beta in Arch Linux (from the gnome-unstable repo), but when I enable Blur My Shell, the screen goes blank. All other extensions I have do not give me any problems (I had disabled extension version validation with gsettings set org.gnome.shell disable-extension-version-validation true to enable extensions there).

Screenshot from 2024-02-23 18-31-16

I can't open any apps while in this state, the overview is also blank.

alissonlauffer avatar Feb 23 '24 21:02 alissonlauffer

Same here. I don't have time now to test, but I guess the cause of the issue is the commit Pass 'radius' to the blur APIs instead of 'sigma'

fjsevilla-dev avatar Feb 24 '24 06:02 fjsevilla-dev

Can confirm that on GNOME 46.rc, Blur My Shell is totally broken leading to a white screen desktop/overview.

Calosis avatar Mar 04 '24 13:03 Calosis

I won't add support right now as there are more than just the sigma name changing for example, styling class names changed); and I have not updated to GNOME 46 yet (I am waiting for fedora 40 beta). I will begin work on this in 1 week or 2.

aunetx avatar Mar 05 '24 13:03 aunetx

Much of the styling for the app grid elements were completely overhauled in GNOME 46 (see here)

An unfortunate result of these changes is that these elements (app tiles, navigation arrows, search result entries) now all have their own (opaque gray) background colors. Unless someone has a better solution, it looks like the Blur My Shell stylesheet will have to be more invasive now as it will have to completely override background colors for these elements for their hover & focus states.

Something like this:

.overview-icon {
    background-color: transparent;
}

.icon-grid .overview-icon:hover, .icon-grid .overview-icon:focus {
    background-color: rgba(100, 100, 100, 0.35);
}

I have a WIP branch if anyone wants to tinker with it.

DaPigGuy avatar Mar 06 '24 02:03 DaPigGuy

Much of the styling for the app grid elements were completely overhauled in GNOME 46 (see here)

An unfortunate result of these changes is that these elements (app tiles, navigation arrows, search result entries) now all have their own (opaque gray) background colors. Unless someone has a better solution, it looks like the Blur My Shell stylesheet will have to be more invasive now as it will have to completely override background colors for these elements for their hover & focus states.

Something like this:

.overview-icon {
    background-color: transparent;
}

.icon-grid .overview-icon:hover, .icon-grid .overview-icon:focus {
    background-color: rgba(100, 100, 100, 0.35);
}

I have a WIP branch if anyone wants to tinker with it.

image you need to change metadata from 45 to 46 and version 55 to 56 but it works thanks please open a PR or maybe @aunetx can use it

ryzendew avatar Mar 12 '24 23:03 ryzendew

you need to change metadata from 45 to 46 and version 55 to 56 but it works thanks please open a PR or maybe @aunetx can use it

~~It doesn't. After compiling and installing the extension from @DaPigGuy fork I still get the white screen. Are you using a different fork?~~

Just realized I forgot to switch branches in his fork… it works fine now.

p0ryae avatar Mar 16 '24 04:03 p0ryae

Hi @DaPigGuy, are you okay with opening a PR with the changes you made? And if it works well for everyone then next release will be for GNOME 46!

By the way, for those that are using this already, is the styling OK for overview elements? As @DaPigGuy said, there should be changes with the css stylesheet, so I don't know how it is precisely without them

aunetx avatar Mar 16 '24 11:03 aunetx

Hi @DaPigGuy, are you okay with opening a PR with the changes you made? And if it works well for everyone then next release will be for GNOME 46!

By the way, for those that are using this already, is the styling OK for overview elements? As @DaPigGuy said, there should be changes with the css stylesheet, so I don't know how it is precisely without them

Using @DaPigGuy branch, everything seems to working well minus the stylesheet issues. See below

image ^ Same with overview (Fedora 40, GNOME 46.rc)

Calosis avatar Mar 16 '24 11:03 Calosis

Hi @DaPigGuy, are you okay with opening a PR with the changes you made? And if it works well for everyone then next release will be for GNOME 46! By the way, for those that are using this already, is the styling OK for overview elements? As @DaPigGuy said, there should be changes with the css stylesheet, so I don't know how it is precisely without them

Using @DaPigGuy branch, everything seems to working well minus the stylesheet issues. See below

image ^ Same with overview (Fedora 40, GNOME 46.rc)

you need to use the newest dash to dock

ryzendew avatar Mar 16 '24 15:03 ryzendew

Hi @DaPigGuy, are you okay with opening a PR with the changes you made? And if it works well for everyone then next release will be for GNOME 46! By the way, for those that are using this already, is the styling OK for overview elements? As @DaPigGuy said, there should be changes with the css stylesheet, so I don't know how it is precisely without them

Using @DaPigGuy branch, everything seems to working well minus the stylesheet issues. See below image ^ Same with overview (Fedora 40, GNOME 46.rc)

you need to use the newest dash to dock

I'm not using dash to dock, both the Dock in the overview and the icons in the overview are broken like seen in the image.

Calosis avatar Mar 16 '24 15:03 Calosis

Hi @aunetx

Unfortunately I will be quite busy this week. Someone will have to figure out the background color styling for all the overview elements to match the new gnome-shell styling (hover, hover+active, focus, focus+hover, focus+hover+active). There also seems to be an issue with app folder blur that needs to be sorted out.

DaPigGuy avatar Mar 16 '24 23:03 DaPigGuy

No problem! I won't be able to test it either (I need to wait for fedora 40 beta, as I use my computer to work so I don't want to have an unusable machine), but my question was more generally if you're okay with me merging your code into the main branch :)

aunetx avatar Mar 17 '24 09:03 aunetx

Yes, go ahead :slightly_smiling_face:

DaPigGuy avatar Mar 18 '24 07:03 DaPigGuy

On Arch (use Endeavour OS who uses Arch repositories) does not work at all: it does not start !!! I updated my OS and went from Gnome 45 to Gnome 46: upon restarting the system, the extension does not start. Can you implement support for Gnome 46?

tux-wclp avatar Mar 24 '24 17:03 tux-wclp

Wait for developers fix that.

rashadgasimli avatar Mar 25 '24 14:03 rashadgasimli

On Arch (use Endeavour OS who uses Arch repositories) does not work at all: it does not start !!! I updated my OS and went from Gnome 45 to Gnome 46: upon restarting the system, the extension does not start. Can you implement support for Gnome 46?

As @ryzendew mentioned above, you can use dconf to remove extension version checking, and build this fork for GNOME 46 (I think it would be merged when @DaPigGuy got all major issues sorted out)

SpikeVN avatar Mar 25 '24 14:03 SpikeVN

image DaPigGuy's git on 46 on Arch. Just to clarify the confusion above from Calosis's post about the icons having frames - this is with the default dock. P.S. if testing is needed, tag me.

d3vilguard avatar Mar 25 '24 21:03 d3vilguard

Hello everyone, could you please test the master branch before I publish the extension? Thanks a lot!

aunetx avatar Mar 25 '24 22:03 aunetx

@d3vilguard if I may tag you ;)

aunetx avatar Mar 25 '24 22:03 aunetx

Version 59 uploaded, should be reviewed soon :)

aunetx avatar Mar 25 '24 23:03 aunetx

image Sorry for the late reply, man was having his beauty sleep. Works just fine.

d3vilguard avatar Mar 26 '24 05:03 d3vilguard