blur-my-shell icon indicating copy to clipboard operation
blur-my-shell copied to clipboard

Blur goes to foreground when new actors are spawned from the same process. (i.e. context menu of nautilus)

Open bertin0 opened this issue 2 years ago • 4 comments

Whenever I open a context menu on e.g. Nautilus or a dropdown in Gnome Settings, all apps for which I have blur enabled get completely blurred, i.e. not just the background but the whole content:

https://user-images.githubusercontent.com/30109573/173417848-eeb17d46-a752-4682-8146-ea7395890e7a.mp4

bertin0 avatar Jun 13 '22 18:06 bertin0

ah.. I think I know why this happens... This won't be a very fun bug to fix haha

CorvetteCole avatar Jul 07 '22 14:07 CorvetteCole

Same problem here, I'd love to see it fixed 💪

xxSkyy avatar Jul 13 '22 23:07 xxSkyy

I'll fix it, but I am very very busy right now. Wish I had more time

CorvetteCole avatar Jul 14 '22 02:07 CorvetteCole

I'm experiencing this too, Anything we can do to help?

EastArctica avatar Jul 17 '22 02:07 EastArctica

image Classic, been around even when this was an extension on it's own as Blur Provider.

SudoVanilla avatar Aug 17 '22 03:08 SudoVanilla

well the common theme between this and blur provider is... me, so maybe it is my fault haha. Really this is somewhat unexpected behavior of gnome switching what window is classified as active or inactive. I've taken a look at this and should be able to fix it when I have a few minutes to do so

CorvetteCole avatar Aug 17 '22 15:08 CorvetteCole

@CorvetteCole that's a great news! Do you have any ETA when it could be fixed?

xxSkyy avatar Aug 17 '22 15:08 xxSkyy

I can't ETA. I famously give ETAs and then miss them by weeks or months. unfortunately still in university + working at a space company part time leaves me less time for my OSS projects than desired. I have not forgotten though, I promise.

CorvetteCole avatar Aug 18 '22 01:08 CorvetteCole

I will fix this soon, I think I know how to do it: instead of adding the child to global.window_group (which sets it aside all the windows), it could be possible to add it as a child of the targeted window itself. This is what I do for the panel for example.

However, if we simply add the blurred box directly as a child of the window, then they won't be displayed properly (as either the blurred box or the app will take all the place). Thus, we need to add a dummy container with a size of 0×0m²; and then add the blurred box as a child of this container. This will make sure that the application layout it untouched, and (by setting the dummy container below the application) that the blurred box is always below the app.

aunetx avatar Aug 20 '22 14:08 aunetx

There is no need to add a dummy container actually, everything works directly

aunetx avatar Aug 20 '22 14:08 aunetx

Just fixed this, was easier than I though

aunetx avatar Aug 20 '22 15:08 aunetx

(there is still a problem with submenus having blur, but I let @CorvetteCole do this -- I really don't know how to know if the actor is a submenu or not)

aunetx avatar Aug 20 '22 15:08 aunetx

so the status now: no issue when right-clicking in e.g. nautilus, but the submenus (e.g. top bar dropdowns) still make blur go to foreground but not for all apps, just for nautilus. this issue persists even after switching workspaces (which used to be the workaround I used to fix things)

bertin0 avatar Aug 21 '22 12:08 bertin0

Hello @bertin0, this should now be entirely fixed as I disabled blur for drop-down/right click menus etc (you may need to wait for the approval on extensions.gnome.org)

I close this as I can't reproduce anything like this anymore, but if there is still and issue, feel free to reopen this one or open another!

aunetx avatar Aug 27 '22 21:08 aunetx

Found another case of this problem in Nautilus image

Repro:

  • Select any file
  • Press F2 to rename it
  • Blur goes foreground

xxSkyy avatar Sep 02 '22 19:09 xxSkyy

Found another case of this problem in Nautilus

* Select any file

* Press `F2` to rename it

* Blur goes foreground

Can confirm it happens to me too

bertin0 avatar Sep 06 '22 22:09 bertin0

Experiencing this issue on GNOME 43 with Blur My Shell 44

Screencast from 2022-12-11 04-08-21.webm

LoganDark avatar Dec 11 '22 12:12 LoganDark

Also having the same issue:

image

image

kaykhan avatar Dec 11 '22 12:12 kaykhan

Same here. Any fixing ideas/attempts? :)

soeoeb avatar Feb 05 '23 21:02 soeoeb

Interesting. I'll take a stab at reproducing this

CorvetteCole avatar Feb 13 '23 16:02 CorvetteCole

~Experiencing this issue again with wezterm. Blur only works properly when first selecting the application window. If you restart it afterwards, blur goes to fg.~

Nevermind, this seems fine when running arch with gnome 44, I had initially tested on Ubuntu with gnome 43.

bertin0 avatar Jun 06 '23 11:06 bertin0

This seems to still be an issue on Wayland

Wayland image

X11 Screenshot from 2023-12-23 12-57-56

PointThink avatar Dec 23 '23 11:12 PointThink