blur-my-shell icon indicating copy to clipboard operation
blur-my-shell copied to clipboard

Blur doesn't fit the dock

Open LMFuture-Me opened this issue 2 years ago • 22 comments

Other Extension: https://extensions.gnome.org/extension/5004/dash-to-dock-for-cosmic/ GNOME: GNOME42.1 OS: 5.17.5 openSUSE Tumbleweed 20220513 Blur My Shell: Ver35 Screenshot from 2022-05-16 16-07-42 Screenshot from 2022-05-16 16-07-39

LMFuture-Me avatar May 16 '22 08:05 LMFuture-Me

Disable "Dash to Dock blur" option in Blur my Shell settings, Can be solved that way in Kali Linux 2022.2 GNOME 42.2

Cuplikan layar dari 2022-06-14 17-10-26

zidansec avatar Jun 14 '22 10:06 zidansec

Bump, have this issue too on Ubuntu 22.04

s7uck avatar Jun 25 '22 08:06 s7uck

Bump, have this issue too on Ubuntu 22.04

It seems to work if you disable the Dash to Dock blur on the Dash tab. And in the Overview tab set Overview components style to Do not style.

ThomasLobker avatar Jul 26 '22 13:07 ThomasLobker

Bump, have this issue too on Ubuntu 22.04

It seems to work if you disable the Dash to Dock blur on the Dash tab. And in the Overview tab set Overview components style to Do not style.

Sure, but that defeats the whole point of the mod XD

s7uck avatar Jul 27 '22 21:07 s7uck

Bump, any updates on this? Although dash to dock 72 hasn't released yet

ludg1e avatar Aug 12 '22 22:08 ludg1e

Sorry, no progress for me; I still can't have non-rectangular blur...

I disabled Dash to Dock blur by default in the extension preferences, so that newcomers won't be disappointed by an ugly rectangular background; however that's the best I can do for the moment.

aunetx avatar Aug 17 '22 10:08 aunetx

@aunetx:

Sorry, no progress for me; I still can't have non-rectangular blur...

I disabled Dash to Dock blur by default in the extension preferences, so that newcomers won't be disappointed by an ugly rectangular background; however that's the best I can do for the moment.

That's fine. The culprit may lie in a missing overflow: hidden rule somewhere in the CSS, however it seems that Gnome's CSS parser never implemented that rule… I did try myself a while back, but was unable to fix anything.

The issue may also just be with Dash to Dock, or Ubuntu's fork of Dash to Dock (they are known for messing up stuff). Gnome's stock dash seems to be unaffected

s7uck avatar Aug 17 '22 18:08 s7uck

This is Dash to Dock's default stylesheet issue. I actually just fixed and got around this issue by deleting their stylesheet and styling the dock properly with my own theme (sorry haven't released mine yet, still working on getting there). image

andrewaclear avatar Aug 25 '22 18:08 andrewaclear

The rectangle issue is GNOME shell's blur limitation currently, but I have gotten the rectangle to perfectly go on just the dock.

andrewaclear avatar Aug 25 '22 18:08 andrewaclear

@andrewaclear Interesting. Please share when possible :)

s7uck avatar Aug 26 '22 08:08 s7uck

For sure, working on that :+1:

andrewaclear avatar Aug 26 '22 18:08 andrewaclear

Any update on this? Dash to dock was recently updated to 42 but the issue still persists> For sure, working on that :+1:

@andrewaclear

Aleksihvon avatar Sep 17 '22 18:09 Aleksihvon

Sounds like a duplicate of #8 ?

vanvugt avatar Sep 20 '22 05:09 vanvugt

My theme is close to being ready, it's just that there are a few bugs due to the new GNOME update (like the volume and brightness pop ups aren't right). I could release it anyways and open these as known issues. The other issue is that Dash to Dock's style sheet actually overrides the theme so I have only been able to fix it by literally deleting their style sheet. I don't know how we can get around this issue unless Dash to Dock literally removes their style sheet. @Aleksihvon

andrewaclear avatar Sep 21 '22 18:09 andrewaclear

@andrewaclear Theming sure can be a pain in GNOME, however i think this project could benefit from you disclosing your fixes and overrides so that we could figure out what it is exactly that's wrong with Dash to Dock's style sheet and if a counter-measure or measures could be implemented for this project to combat it and perhaps similar issues. From your shares the Theme is looking very good, i'll be looking out for its release.

Aleksihvon avatar Sep 21 '22 20:09 Aleksihvon

Hi everyone,

I was looking for some answers about problems between blur my shell and dash to dock I have classical symptoms, rectangle blurry corners that don't fit with dash to dock and some "artifacts" or "print" when I hover an app

image

But after reading this thread, it seems to be a really tough problem If I understood well, is a shaped blur impossible because of gnome ? Or Xorg / Wayland ?

I was about to ask you if you need some help to code a fix, but I'm not even sure we can fix that through blur my shell

PS : Nice job for this nice extension

TeoConan avatar Oct 11 '22 21:10 TeoConan

It's not trivial, but in theory all it needs is for blur-my-shell to not modify the alpha channel and thus keep the original shape of the dock. In OpenGL that is done by glColorMask. I'm not yet sure if mutter/cogl exposes enough functionality for gnome-shell + extensions to do it though.

vanvugt avatar Oct 12 '22 02:10 vanvugt

It's not trivial, but in theory all it needs is for blur-my-shell to not modify the alpha channel and thus keep the original shape of the dock. In OpenGL that is done by glColorMask. I'm not yet sure if mutter/cogl exposes enough functionality for gnome-shell + extensions to do it though.

I'm sorry I can reply further, but no, it is not "just" not modify the alpha channel, and it is in fact way harder than this... It would require me to write an entire dynamic blur effect, which I don't have any idea how to do as I use the internal gnome shell one. So it is indeed a bug coming from gnome shell, and except if I have a very big (very very big) pull request implementing all of this, or more simply a fix in gnome-shell, which could be done if the developpers want to (but I honestly understand that they don't want to spend time on it)

aunetx avatar Oct 12 '22 08:10 aunetx

OK, that makes it a feature that gnome-shell is missing, causing a bug here.

vanvugt avatar Oct 12 '22 08:10 vanvugt

Folks! I am happy with the following workaround: image Which gives as result: image Sure, I cannot choose the alpha and style of background, but is fine for me. @aunetx Thanks for this beautiful gnome extension!

sscansan avatar Apr 20 '23 15:04 sscansan

My theme is close to being ready, it's just that there are a few bugs due to the new GNOME update (like the volume and brightness pop ups aren't right). I could release it anyways and open these as known issues. The other issue is that Dash to Dock's style sheet actually overrides the theme so I have only been able to fix it by literally deleting their style sheet. I don't know how we can get around this issue unless Dash to Dock literally removes their style sheet. @Aleksihvon

My dude, can you PLEASE show how you achieve that? I was messing with the themes for two hours now and were able to fix it kinda but i still have problem with the rectangle when it goes over a window:

Screenshot from 2023-04-24 22-26-02 Screenshot from 2023-04-24 22-26-07

If you could just provide a general outline that would be so effing great. You said you were to share your theme but i searched your github and found nothing. A little help would be awesome!

hrqmonteiro avatar Apr 25 '23 01:04 hrqmonteiro

Folks! I am happy with the following workaround: image Which gives as result: image Sure, I cannot choose the alpha and style of background, but is fine for me. @aunetx Thanks for this beautiful gnome extension!

That is not blurring, it just makes the dock transparent, unfortunately.

hrqmonteiro avatar Apr 25 '23 01:04 hrqmonteiro

Hello! With the latest update on GNOME 46, this is finally fixed as you can add corners for the dock (which is done automatically by default). Hope you will enjoy it!

aunetx avatar Apr 19 '24 15:04 aunetx